Nicolas Silva [:nical] Reporter
	Description • 9 years ago

Moz2D needs to create some threads so I copy-pased this from the js engine https://dxr.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680/js/src/vm/PosixNSPR.cpp#148 which lets me have thread names, but task cluster build turns orange: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a8d863565417

Moz2D cannot use nspr xpcom or any gecko dependency except mfbt. How can I get thread names to work (like js).

	Pulsebot
	Comment 1 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/1274c73440b8

	Nicolas Silva [:nical] Reporter
	Comment 2 • 9 years ago

ASAN builds are also affected.

	Nicolas Silva [:nical] Reporter
	Comment 3 • 9 years ago

These checks appear to be rather new since the same code worked 4 days ago, but grep doesn't find the error message in mozilla-inbound.

	Nicolas Silva [:nical] Reporter
	Comment 4 • 9 years ago

The patch that removes the call to pthread_setname_np to get inbound green. It'd be great to have thread names back in Moz2D, though.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/1274c73440b8

	Nicolas Silva [:nical] Reporter
	Comment 6 • 9 years ago

Mike, is there something I can do in moz2d to be able to use pthread_setname_np like the js engine does (without depending on xpcom or js)?

	Mike Hommey [:glandium]
	Comment 7 • 9 years ago

That code from the js engine is not used in Firefox, that's why it's not causing problems. I think the reasonable thing for you to do is to use NSPR and have stubs when not building within Firefox, which is what the js engine has.

	Mike Hommey [:glandium]
	Comment 8 • 9 years ago

(or use thread pools from xpcom, btw)

	Sylvestre Ledru [:Sylvestre]
	Comment 9 • 6 years ago

Nical, Can we close this bug now? Thanks