Nicolas Silva [:nical] Assignee
	Description • 9 years ago

Tracking bug for the job scheduler.

	Nicolas Silva [:nical] Assignee
	Comment 1 • 7 years ago

We dropped the idea of multi-threaded tile rendering so we don't have a use case for this right now, there are bitrotted patches pending on reviews for a year, and more importantly several seconds spent running the scheduler tests in each push, which is a waste of infra since we don't have plans to use this in the foreseeable future.

If we look into something like this again in the future, rust would be a much better place for building this type of system.

	Pulsebot
	Comment 2 • 7 years ago

Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/009af86a3026
Remove the gfx job scheduler. r=jrmuizel

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 3 • 7 years ago

Backed out for build bustage at StyleSheetInlines.h(77):

https://hg.mozilla.org/integration/mozilla-inbound/rev/494b52e3b462caafa3cae7832b58fb0dbd589925

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=009af86a30269949fa6777db130722b975c9605b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=120655241&repo=mozilla-inbound

09:10:04     INFO -  Unified_cpp_gfx_tests_gtest0.cpp
09:10:04     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/StyleSheetInlines.h(77): error C2287: 'mozilla::StyleSheet': inheritance representation: 'single_inheritance' is less general than the required 'multiple_inheritance'
09:10:04     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/StyleSheetInfo.h(17): note: see declaration of 'mozilla::StyleSheet'
09:10:04     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/StyleSheetInlines.h(77): fatal error C1903: unable to recover from previous error(s); stopping compilation
09:10:04     INFO -  z:/build/build/src/config/rules.mk:1050: recipe for target 'Unified_cpp_gfx_tests_gtest0.obj' failed
09:10:04     INFO -  mozmake.EXE[5]: *** [Unified_cpp_gfx_tests_gtest0.obj] Error 2

	Jeff Muizelaar [:jrmuizel]
	Comment 4 • 7 years ago

We should reland this.

	Nicolas Silva [:nical] Assignee
	Comment 5 • 7 years ago

Pushed this to try again today and the windows builds are still failing on some mysterious and unrelated code, due to unified build hazards I presume. https://treeherder.mozilla.org/#/jobs?repo=try&author=nsilva@mozilla.com&selectedJob=130637149

This is pretty far down my list, so I don't think I'll investigate it in the short term. We could comment out the test as a short term thing if we want to save some infra.

	Pulsebot
	Comment 7 • 4 years ago

Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8999f97966d2
Remove the multi-threaded job scheduler. r=jrmuizel

	Pulsebot
	Comment 9 • 4 years ago

Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e279dd585ca7
Remove the multi-threaded job scheduler. r=jrmuizel