Closed
Bug 1212177
Opened 9 years ago
Closed 9 years ago
l10n repacks should be displayed in treeherder properly
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P2)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: KWierso)
References
Details
Attachments
(2 files, 3 obsolete files)
* They should be grouped
* The symbol should be not a question mark
Updated•9 years ago
|
Assignee: nobody → kmoir
Comment 1•9 years ago
|
||
pull request https://github.com/mozilla/treeherder/pull/1176
Comment 2•9 years ago
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Component: Release Automation → Treeherder: Data Ingestion
Priority: -- → P2
Product: Release Engineering → Tree Management
QA Contact: bhearsum
Version: unspecified → ---
Comment 3•9 years ago
|
||
We use Bugzilla review flags to track reviews, which is why the PR hasn't been looked at until now (particularly since we didn't see this bug, since it was in another product/component).
I've left a comment on the PR - when that's addressed (and the branch force pushed to update the PR) if you flag me for review on the existing attachment (it's just a link to the PR so can be re-used) I'll take a look and get this landed for you asap :-)
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
It looks like this latest PR needs some test fixes. Would you be able to address those? [lizzard:] was mentioning in IRC that those tests just show as "?" at this point.
Flags: needinfo?(kmoir)
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Autolander from comment #7)
> Created attachment 8738244 [details]
> [treeherder] KWierso:bug1212177v2 > mozilla:master
This is just Kim's branch with the fixes I linked to squashed in, and rebased onto the current master branch. I make no promises that the fixes I added won't break something else since I basically took Kim's PR and smashed my face into it until the test stopped failing...
But on the bright side, none of the tests are failing. :)
Assignee | ||
Updated•9 years ago
|
Attachment #8707948 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8733035 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8733396 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8738244 -
Flags: review?(cdawson)
Updated•9 years ago
|
Attachment #8738244 -
Flags: review?(cdawson) → review+
Comment 10•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/6715629ab737c767aaeba1167d550bd212354ebf
Bug 1212177 - l10n repacks should be displayed in treeherder properly
https://github.com/mozilla/treeherder/commit/7f6423f2b7c250a920227664669e935f6b1c4515
Merge pull request #1391 from KWierso/bug1212177v2
Bug 1212177 - l10n repacks should be displayed in treeherder properly
Comment 11•9 years ago
|
||
Awesome Wes, thank you for fixing this! :-)
Assignee: kmoir → wkocher
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•