Closed
Bug 1214569
Opened 9 years ago
Closed 9 years ago
[User Story] Unpin page from pin dialog
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benfrancis, Assigned: gmarty)
References
Details
(Keywords: feature, Whiteboard: [systemsfe])
User Story
As a user I want to unpin a page from the pin dialog
Attachments
(1 file)
No description provided.
|
||
Comment 1•9 years ago
|
||
Hi Ben,
This user story should be the last feature of 2.5 not yet landed, right?
Is bug 1168970 still 2.5+ for feature-b2g?
Flags: needinfo?(bfrancis)
|
Reporter | |
Comment 2•9 years ago
|
||
Correct, this was a late feature request and we can live without it but nice to have.
Bug 1168970 is still 2.5+, the work was done in bug 1202571 so I've resolved it FIXED :)
Flags: needinfo?(bfrancis)
|
|
||
Comment 3•9 years ago
|
||
Hi Ben,
Good to know that we only have one unfinished feature remains!
I think this user story is very important. Without it, the inconsistent display on pin dialog (eg, still show "pin" button when navigates to a already pinned page/site) would make user feel confused.
Thus, can we make this user story as 2.5+ for feature-b2g?
Flags: needinfo?(bfrancis)
|
|
Reporter | |
Comment 4•9 years ago
|
||
This was a late feature request and wasn't part of the MVP but would be nice to have.
Because we can't yet rearrange pinned pages on the homescreen it's actually quite handy to be able to re-pin a page to bring it to the top of the list.
We will aim to fix this for 2.5 but it shouldn't block the release.
Flags: needinfo?(bfrancis)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gmarty
|
||
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8676332 [details]
[gaia] gmarty:Bug-1214569-Unpin-page-from-pin-dialog > mozilla-b2g:master
Hey, Alberto, what do you think of this patch?
Attachment #8676332 -
Flags: review?(apastor)
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8676332 [details]
[gaia] gmarty:Bug-1214569-Unpin-page-from-pin-dialog > mozilla-b2g:master
Styling comment in GH (feel free to don't fix it if you disagree). r=me with a nice UI test that covers unpining a page :). We'll cover all the cases after that!
Thanks!
Attachment #8676332 -
Flags: review?(apastor) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•