Closed
Bug 121506
Opened 23 years ago
Closed 17 years ago
Make InstallTrigger a scriptable component
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Core Graveyard
Installer: XPInstall Engine
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: samir_bugzilla, Assigned: dveditz)
References
Details
(Whiteboard: custrtm+)
Currently, we can get to the InstallTrigger instantiation via a DOM window.
But, when XPInstall is disabled the InstallTrigger methods don't do any work
(they look at the pinstall.enalbed pref and bail if it's false). The update
notifications client of InstallTrigger is one case where we need InstallTrigger
to be a component (that we can get directly) so that we don't get affected by
whether XPInstall is disbaled or enabled (since update notifications can be
enabled/disabled separately from XPInstall being enabled/disabled). This also
entails moving the check for xpinstall.enabled out of the InstallTrigger code
into the install trigger JS glue.
Assignee | ||
Comment 1•23 years ago
|
||
Or, I might add, create an additional pref on whether web content can use the
InstallTrigger object to check versions. I can imagine scenarios where someone
would want XPInstall itself on, but disable version sniffing. In any case
privileged code should be able to bypass those checks.
Comment 2•23 years ago
|
||
nominating for nsbeta1. This blocks a top priority Mozilla1.0/MachV feature.
Keywords: nsbeta1
Reporter | ||
Comment 3•23 years ago
|
||
Adding dependency of update notifications on this work.
Blocks: 120201
Dan, could you plus or minus this, and if plus, give it mozilla 0.9.9 or mozilla
1.0?
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•23 years ago
|
||
Not too hard: we're already a component, just not a scriptable one.
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.0
minusing per adt traige
Reporter | ||
Comment 7•23 years ago
|
||
We need this to break the only dependency of nsUpdateNotifier.js on the hidden
DOM window. CC'ing danm so he can renominate for nsbeta1 if he feels strongly
that Mach V shouldn't ship with this dependency.
You're not using the hidden window as a parent of some dialog window (right?).
If I remember correctly, you're using its JS context in a component because you
don't have a window to use. If that's correct, I agree with the nsbeta1-. The
hidden window won't be removed any time soon. This is another case where there's
no alternative I can think of.
Reporter | ||
Comment 9•23 years ago
|
||
Well, the alternative is to fix this bug. But sure, nsbeta1- sounds fine by me too.
Comment 10•22 years ago
|
||
In some cases, enterprise IT admin might want to disable xpinstall but keep
update notification. -> custrtm+
Whiteboard: custrtm+
Assignee | ||
Comment 11•17 years ago
|
||
The xpinstall script engine has been removed from the trunk, bugs in it are obsolete.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•