Anthony, can you provide a mock-up (or just a comment) listing the finalized spec for the new settings organization?

(Not including some of the renaming suggestions from the study for scope reasons) Top-level --- Sign in / user@email.com (bug 1189356) General Search Privacy Accessibility Advanced Mozilla Clear private data Second-level in --- Sign in General - Home - Language - Title bar Search - Keep as is Privacy - Do not track - Tracking Protection - Cookies - Manage logins - Remember logins - Use master password - Clear private data on exit - Data sharing choices -- Telemetry -- Crash reporter -- Mozilla Location Service -- Health report Accessibility - Always enable zoom - Full-screen browsing - Text size Items not accounted for in the study but I think could belong in "Accessibility" as well: *-------------------------* | - Magnify small areas | | - Voice input | | - QR input | *-------------------------* Advanced - Import from Android - Download updates automatically - Tabs (Can we call this "Restore tabs"?) - Plugins - Allow Autoplay - Character encoding - Paint flashing - Remote debugging Mozilla - Keep as is Clear private data now Does this work Margaret?

Thanks Anthony! I'm updating this slightly to include the findings form both Card Sort #1 and Card Sort #2. Happy to discuss any inconsistencies. I agree that the new items work under Accessibility. Also, FYI - I did not test item order within categories. So what you see here is not necessarily prescriptive of order. Top-level --- Sign In / user@email.com (bug 1189356) General & Accessibility (maybe make Accessibility a sub-heading?) Search Privacy Advanced About Firefox Clear Private Data Make Default Browser (if possible....) Second-level in --- Sign in General & Accessibility - Home - Language - Title bar - Always Enable Zoom - Full-screen Browsing - Text Size - Magnify small areas - Voice input - QR input Search - Add More Search Providers - Installed Search Engines - Show Search Suggestions Privacy - Do not track - Tracking Protection - Cookies - Manage logins - Remember logins - Use master password - Clear private data on exit - Data sharing choices -- Telemetry -- Crash reporter -- Mozilla Location Service -- Health report Advanced - Import Options - Automatic Updates - Restore Tabs - Plugins - Allow Autoplay - Character encoding - Paint flashing - Remote debugging About Firefox - About Mozilla - FAQs - Give Feedback Clear private data now Make Default Browser

Also, two comments for consideration: Margaret - Character Encoding might be important enough in some regions to move to General & Accessibility. Barbara - Import Options might need to be moved to General & Accessibility so it doesn’t seem intimidating to the average user.

Talked to Gemma and I'm gonna make a final pass at this. And I think it's ready to go Margaret :) Top-level --- Sign In / user@email.com (bug 1189356) General Search Privacy Accessibility Advanced About Firefox Clear Private Data Make Default Browser (if possible....) Second-level in --- Sign in General - Home - Language - URL bar - Always enable zoom - Full-screen browsing Search - Add more search providers - Installed search engines - Show search suggestions Privacy - Do not track - Tracking protection - Cookies - Manage logins - Remember logins - Use master password - Clear private data on exit - Data sharing choices -- Telemetry -- Crash reporter -- Mozilla Location Service -- Health report Accessibility - Text size - Magnify small areas - Voice input - QR input Advanced - Import options - Automatic updates - Restore Tabs - Click-to-play images - Plugins - Allow Autoplay - Character encoding - Paint flashing - Remote debugging About Mozilla - About Firefox - FAQs - Give Feedback Clear private data now Make Default Browser (Is this do-able? I forget now)

Quick update. Talked to Gemma about "About Mozilla". The last item in this list. It _was_ a bit awkward to see "Mozilla" and I'm in agreement that making it "Firefox" makes more sense here. Particularly because that's how most of our user facing messaging tends to label us. Being in the "Firefox" app just seems to reinforce this and confuse users when they see "Mozilla". For reasons of familiarity, we think it best to go with: Firefox - About Firefox - FAQs - Give feedback Gemma, feel free to correct me if I'm wrong!

Anthony and I had another chat about this and we are revising our recommendation for the Firefox/About section :) We propose: Mozilla Firefox - About Firefox - FAQs - Give feedback Thanks!

(In reply to Anthony Lam (:antlam) from comment #4) > Top-level > --- > Sign In / user@email.com (bug 1189356) > General > Search > Privacy > Accessibility > Advanced > About Firefox > Clear Private Data > Make Default Browser (if possible....) Another concern: on tablets, we have a split-pane view, so everything that's at the "top-level" there needs to actually be a category. So I think we'll need to tuck "Clear Private Data" into one of them. Maybe we should put it under "General", since that's the first category that's automatically selected?

Perhaps under Privacy? Would this be tucked only for Tablet's or for Mobile devices also? Cause we _could_ also just create a "Clear private data" category with "clear now" in it..? Open to suggestions

I noticed that "Clear private data" is hidden below the fold on my N4 with the proposed configuration. I'm not sure what we could do to make it obvious that this screen scrolls, or how much we've customized the style of this list ourselves, but I think this is a discoverability problem.

Although this will be re-organized, I had a look at Telemetry UI and noticed the following top clicks in settings: For release (in order of # of clicks): preferences_privacy sync_setup preferences_customize preferences_display preferences_vendor preferences_customize_tablet preferences_home preferences_devtools preferences_search preferences_locale sync_settings We might want to align ourselves with those So here my suggestion for now for top level: Sign In (we want people to sign in) General Privacy Clear Private Data Accessibility Search Advanced Make Default Browser About Firefox

(In reply to Anthony Lam (:antlam) from comment #8) > Perhaps under Privacy? That's the natural place to find it, but the reason we decided to surface it at the top level is that people do this all the time. > Would this be tucked only for Tablet's or for Mobile devices also? We can do whatever we want. The only constraint is that top-level items on tablet all need to have some content that they display on the right side of the screen. > Cause we _could_ also just create a "Clear private data" category with > "clear now" in it..? Open to suggestions True. Although we decided not to do that for sync. But then again, sync fits well into "General", but "Clear private data" might be weird if there's a separate "Privacy" category. New question: Where should "Open multiple links" go? My first instinct is "Advanced", but if this is a key differentiator we want to promote, should we put it in "General"?

(In reply to Barbara Bermes [:barbara] from comment #10) > Although this will be re-organized, I had a look at Telemetry UI and noticed > the following top clicks in settings: > > For release (in order of # of clicks): > preferences_privacy > sync_setup > preferences_customize > preferences_display > preferences_vendor > preferences_customize_tablet > preferences_home > preferences_devtools > preferences_search > preferences_locale > sync_settings > > We might want to align ourselves with those > > So here my suggestion for now for top level: > > Sign In (we want people to sign in) > General > Privacy > Clear Private Data > Accessibility > Search > Advanced > Make Default Browser > About Firefox I'd like to hear Anthony and Gemma's opinions on this change. One tricky thing about telemetry is that they way things are organize might influence how often they're used. For example, search is pretty buried right now - maybe more people would use it if it's at the top level? Although I do like the idea of placing "Clear Private Data" next to "Privacy".

(In reply to :Margaret Leibovic from comment #11) > New question: Where should "Open multiple links" go? My first instinct is > "Advanced", but if this is a key differentiator we want to promote, should > we put it in "General"? I think this falls squarely in "Advanced". (In reply to :Margaret Leibovic from comment #12) > (In reply to Barbara Bermes [:barbara] from comment #10) > > Although this will be re-organized, I had a look at Telemetry UI and noticed > > the following top clicks in settings: > > > > For release (in order of # of clicks): > > preferences_privacy > > sync_setup > > preferences_customize > > preferences_display > > preferences_vendor > > preferences_customize_tablet > > preferences_home > > preferences_devtools > > preferences_search > > preferences_locale > > sync_settings > > > > We might want to align ourselves with those > > > > So here my suggestion for now for top level: > > > > Sign In (we want people to sign in) > > General > > Privacy > > Clear Private Data > > Accessibility > > Search > > Advanced > > Make Default Browser > > About Firefox > > I'd like to hear Anthony and Gemma's opinions on this change. One tricky > thing about telemetry is that they way things are organize might influence > how often they're used. For example, search is pretty buried right now - > maybe more people would use it if it's at the top level? > > Although I do like the idea of placing "Clear Private Data" next to > "Privacy". From my experience and what we've observed, the current telemetry data is more of a reflection of how crazy our current ordering and hierarchy is. Take "Customize" and "Display" for example, both are pretty confusing and they're placed next to each other. It's fairly common to just click into and back out of both categories until one finds what they're looking for. Given that I'm pretty confident in Gemma's findings and her suggested top level also is derived from this research, I'd like to reorganize based on our suggestions. There will be a cost of change for sure, but in the long run, I think it's going to be worth it.

(In reply to :Margaret Leibovic from comment #9) > Created attachment 8677100 [details] > "Clear private data" hidden below the fold > > I noticed that "Clear private data" is hidden below the fold on my N4 with > the proposed configuration. I'm not sure what we could do to make it obvious > that this screen scrolls, or how much we've customized the style of this > list ourselves, but I think this is a discoverability problem. I'm not too concerned with the "fold" in this case. Android is really diverse and in the long run, I think it makes sense to make these decisions more from an informational hierarchy point of view. These were things Gemma and I considered too when placing this at the bottom of the list. Gemma can chime in about this a bit more but I think placing this at the bottom made sense too because we were grouping the "actions" together. "Clear data" and "Make default" are more "action" orientated things that don't require "setting" anything. This "one and done" nature to them made more sense at the ends of the list rather than sandwiched between other prefs. That being said, I'd be open to moving both "Clear Private data" and "Make default browser" to be above "Mozilla Firefox". That is the only other category I think that makes sense at the bottom of this list. For clarity, this is what we currently have (barring feedback about comment 14) > Top-level > --- > Sign In / user@email.com > General > Search > Privacy > Accessibility > Advanced > Mozilla Firefox > Clear Private Data > Make Default Browser

(In reply to Anthony Lam (:antlam) from comment #4) > General > - Home > - Language > - URL bar > - Always enable zoom > - Full-screen browsing > Accessibility > - Text size > - Magnify small areas > - Voice input > - QR input I'd like to push 'Always enable zoom' from 'General' to 'Accessibility', since it is definitely an a11y feature. Not having it in 'Accessibility' feels broken from an a11y standpoint.

Bug 1216257 - Rename "Customize" category to "General" r?sebastian

Bug 1216257 - Move "Search" category to top level r?sebastian

Bug 1216257 - Rename "Display" category to "Accessibility" r?sebastian

Bug 1216257 - Rename "Developer Tools" category to "Advanced" r?sebastian

Bug 1216257 - Move "Language" settting to "General" section r?rnewman

Bug 1216257 - Move clear private data setting to top level. r?sebastian

Bug 1216257 - Move restore tabs pref from to "Advanced". r?sebastian

Bug 1216257 - Move tap-to-load images pref from to "Advanced". r?sebastian

Bug 1216257 - Move titlebar pref to "General". r?sebastian

Bug 1216257 - Move zoom and full-screen browsing prefs to "General". r?sebastian

Bug 1216257 - Rearrange search settings to match spec. r?sebastian

Bug 1216257 - Rearrange privacy prefs to match spec. r?sebastian

Bug 1216257 - Move data reporting prefs to "Privacy". r?sebastian

Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r?sebastian

Bug 1216257 - Remove disabled tests and associated strings. r?gbrown

Here's a build to test: http://people.mozilla.org/~mleibovic/fennec-settings.apk Anthony, let me know what you think and what needs to be changed. Let's try to stay focused on only the reorganization here, and we can deal with renaming things in future bugs. One thing to note is that I just made up new summary text for the categories. We should think about what we actually want those to be.

(In reply to :Margaret Leibovic from comment #35) > Here's a build to test: > http://people.mozilla.org/~mleibovic/fennec-settings.apk Actually, use this: http://archive.mozilla.org/pub/mobile/try-builds/mleibovic@mozilla.com-24d9aa5169028a6d2f80202c044db3fa3e3fe7b3/try-android-api-11/fennec-44.0a1.en-US.android-arm.apk

Comment on attachment 8678980 [details] MozReview Request: Bug 1216257 - Remove disabled tests and associated strings. r=gbrown https://reviewboard.mozilla.org/r/23319/#review20763 Nice cleanup - thanks! I think it is a good idea to delete tests that are disabled unless we have realistic plans to revive them: I worry about the clutter and the possible mis-perception that we have test coverage when we actually do not. ::: mobile/android/tests/browser/robocop/robocop.ini:60 (Diff revision 1) > # disabled on 2.3; bug 979603 > # disabled on 4.0; bug 1006242 > # skip-if = android_version == "10" || android_version == "15" I think these 3 comments must be associated with testMasterPassword too.

Comment on attachment 8678966 [details] MozReview Request: Bug 1216257 - Rename "Customize" category to "General" r=sebastian https://reviewboard.mozilla.org/r/23291/#review20769

Comment on attachment 8678967 [details] MozReview Request: Bug 1216257 - Move "Search" category to top level r=sebastian https://reviewboard.mozilla.org/r/23293/#review20771

Comment on attachment 8678968 [details] MozReview Request: Bug 1216257 - Rename "Display" category to "Accessibility" r=sebastian https://reviewboard.mozilla.org/r/23295/#review20773 ::: mobile/android/base/preferences/GeckoPreferences.java:18 (Diff revision 1) > import org.mozilla.gecko.GeckoEvent; > +import org.mozilla.gecko.GeckoEvent; This import is duplicated.

Comment on attachment 8678969 [details] MozReview Request: Bug 1216257 - Rename "Developer Tools" category to "Advanced" r=sebastian https://reviewboard.mozilla.org/r/23297/#review20775

Comment on attachment 8678971 [details] MozReview Request: Bug 1216257 - Move clear private data setting to top level. r=sebastian https://reviewboard.mozilla.org/r/23301/#review20777 Follow-up?: This setting is currently visible in restricted profiles (with "Disable 'Clear browsing history'" enabled).

Comment on attachment 8678972 [details] MozReview Request: Bug 1216257 - Move restore tabs pref from to "Advanced". r=sebastian https://reviewboard.mozilla.org/r/23303/#review20779

Comment on attachment 8678973 [details] MozReview Request: Bug 1216257 - Move tap-to-load images pref from to "Advanced". r=sebastian https://reviewboard.mozilla.org/r/23305/#review20781

(In reply to Mark Finkle (:mfinkle) from comment #19) > (In reply to Anthony Lam (:antlam) from comment #4) > > > General > > - Home > > - Language > > - URL bar > > - Always enable zoom > > - Full-screen browsing > > > Accessibility > > - Text size > > - Magnify small areas > > - Voice input > > - QR input > > I'd like to push 'Always enable zoom' from 'General' to 'Accessibility', > since it is definitely an a11y feature. Not having it in 'Accessibility' > feels broken from an a11y standpoint. I'm OK with this too. (In reply to :Margaret Leibovic from comment #36) > (In reply to :Margaret Leibovic from comment #35) > > Here's a build to test: > > http://people.mozilla.org/~mleibovic/fennec-settings.apk > > Actually, use this: > http://archive.mozilla.org/pub/mobile/try-builds/mleibovic@mozilla.com- > 24d9aa5169028a6d2f80202c044db3fa3e3fe7b3/try-android-api-11/fennec-44.0a1.en- > US.android-arm.apk This is looking good! I'll file a bug for the first round of copy updates as per our research :)

^Thanks Margaret! I filed bug 1218557 for the copy nits. So between that and bug 1189356, we should be in good shape :D

Comment on attachment 8678974 [details] MozReview Request: Bug 1216257 - Move titlebar pref to "General". r=sebastian https://reviewboard.mozilla.org/r/23307/#review20869

Comment on attachment 8678975 [details] MozReview Request: Bug 1216257 - Move full-screen browsing pref to "General". r=sebastian https://reviewboard.mozilla.org/r/23309/#review20871

Comment on attachment 8678976 [details] MozReview Request: Bug 1216257 - Rearrange search settings to match spec. r=sebastian https://reviewboard.mozilla.org/r/23311/#review20873

Comment on attachment 8678977 [details] MozReview Request: Bug 1216257 - Rearrange privacy prefs to match spec. r=sebastian https://reviewboard.mozilla.org/r/23313/#review20877

Comment on attachment 8678978 [details] MozReview Request: Bug 1216257 - Move data reporting prefs to "Privacy". r=sebastian https://reviewboard.mozilla.org/r/23315/#review20879

Comment on attachment 8678979 [details] MozReview Request: Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r=sebastian https://reviewboard.mozilla.org/r/23317/#review20881

(In reply to Anthony Lam (:antlam) from comment #45) > (In reply to Mark Finkle (:mfinkle) from comment #19) > > (In reply to Anthony Lam (:antlam) from comment #4) > > > > > General > > > - Home > > > - Language > > > - URL bar > > > - Always enable zoom > > > - Full-screen browsing > > > > > Accessibility > > > - Text size > > > - Magnify small areas > > > - Voice input > > > - QR input > > > > I'd like to push 'Always enable zoom' from 'General' to 'Accessibility', > > since it is definitely an a11y feature. Not having it in 'Accessibility' > > feels broken from an a11y standpoint. > > I'm OK with this too. Good point. I agree.

(In reply to Anthony Lam (:antlam) from comment #15) > (In reply to :Margaret Leibovic from comment #9) > > Created attachment 8677100 [details] > > "Clear private data" hidden below the fold > > > > I noticed that "Clear private data" is hidden below the fold on my N4 with > > the proposed configuration. I'm not sure what we could do to make it obvious > > that this screen scrolls, or how much we've customized the style of this > > list ourselves, but I think this is a discoverability problem. > > I'm not too concerned with the "fold" in this case. Android is really > diverse and in the long run, I think it makes sense to make these decisions > more from an informational hierarchy point of view. These were things Gemma > and I considered too when placing this at the bottom of the list. > > Gemma can chime in about this a bit more but I think placing this at the > bottom made sense too because we were grouping the "actions" together. > "Clear data" and "Make default" are more "action" orientated things that > don't require "setting" anything. This "one and done" nature to them made > more sense at the ends of the list rather than sandwiched between other > prefs. > > That being said, I'd be open to moving both "Clear Private data" and "Make > default browser" to be above "Mozilla Firefox". That is the only other > category I think that makes sense at the bottom of this list. > > For clarity, this is what we currently have (barring feedback about comment > 14) > > > Top-level > > --- > > Sign In / user@email.com > > General > > Search > > Privacy > > Accessibility > > Advanced > > Mozilla Firefox > > Clear Private Data > > Make Default Browser I think it would be fine to move Clear and Default above Mozilla Firefox. Mozilla Firefox feels like a natural final item to me.

Comment on attachment 8678970 [details] MozReview Request: Bug 1216257 - Move "Language" settting to "General" section r=rnewman https://reviewboard.mozilla.org/r/23299/#review21043 ::: mobile/android/base/preferences/GeckoPreferenceFragment.java:100 (Diff revision 1) > +// } Clean up commented-out code. ::: mobile/android/base/preferences/GeckoPreferences.java:289 (Diff revision 1) > - updateTitle(R.string.pref_header_language); > + updateTitle(R.string.pref_header_general); Leave a comment for why we do this, now you know :) ::: mobile/android/base/preferences/GeckoPreferences.java:500 (Diff revision 1) > - if (header.id == R.id.pref_header_language && !localeSwitchingIsEnabled) { > + if (header.id == R.id.pref_header_advanced && !RestrictedProfiles.isAllowed(this, Restriction.DISALLOW_DEVELOPER_TOOLS)) { Why did you get rid of this? We still need to hide this pref if local switching is disabled. That might mean moving this to a section check or the individual pref checks. s/settting/setting

(In reply to Richard Newman [:rnewman] from comment #55) > ::: mobile/android/base/preferences/GeckoPreferences.java:500 > (Diff revision 1) > > - if (header.id == R.id.pref_header_language && !localeSwitchingIsEnabled) { > > + if (header.id == R.id.pref_header_advanced && !RestrictedProfiles.isAllowed(this, Restriction.DISALLOW_DEVELOPER_TOOLS)) { > > Why did you get rid of this? We still need to hide this pref if local > switching is disabled. That might mean moving this to a section check or the > individual pref checks. This just hides the header for tablets. We already have separate logic to remove the actual pref: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/GeckoPreferences.java#684 I tested with locale switching disabled, and the pref was hidden as expected.

Comment on attachment 8678966 [details] MozReview Request: Bug 1216257 - Rename "Customize" category to "General" r=sebastian Bug 1216257 - Rename "Customize" category to "General" r=sebastian

Comment on attachment 8678967 [details] MozReview Request: Bug 1216257 - Move "Search" category to top level r=sebastian Bug 1216257 - Move "Search" category to top level r=sebastian

Comment on attachment 8678968 [details] MozReview Request: Bug 1216257 - Rename "Display" category to "Accessibility" r=sebastian Bug 1216257 - Rename "Display" category to "Accessibility" r=sebastian

Comment on attachment 8678969 [details] MozReview Request: Bug 1216257 - Rename "Developer Tools" category to "Advanced" r=sebastian Bug 1216257 - Rename "Developer Tools" category to "Advanced" r=sebastian

Comment on attachment 8678966 [details] MozReview Request: Bug 1216257 - Rename "Customize" category to "General" r=sebastian Bug 1216257 - Rename "Customize" category to "General" r=sebastian

Comment on attachment 8678970 [details] MozReview Request: Bug 1216257 - Move "Language" settting to "General" section r=rnewman Bug 1216257 - Move "Language" settting to "General" section r=rnewman

Comment on attachment 8678967 [details] MozReview Request: Bug 1216257 - Move "Search" category to top level r=sebastian Bug 1216257 - Move "Search" category to top level r=sebastian

Comment on attachment 8678971 [details] MozReview Request: Bug 1216257 - Move clear private data setting to top level. r=sebastian Bug 1216257 - Move clear private data setting to top level. r=sebastian

Comment on attachment 8678968 [details] MozReview Request: Bug 1216257 - Rename "Display" category to "Accessibility" r=sebastian Bug 1216257 - Rename "Display" category to "Accessibility" r=sebastian

Comment on attachment 8678969 [details] MozReview Request: Bug 1216257 - Rename "Developer Tools" category to "Advanced" r=sebastian Bug 1216257 - Rename "Developer Tools" category to "Advanced" r=sebastian

Comment on attachment 8678972 [details] MozReview Request: Bug 1216257 - Move restore tabs pref from to "Advanced". r=sebastian Bug 1216257 - Move restore tabs pref from to "Advanced". r=sebastian

Comment on attachment 8678970 [details] MozReview Request: Bug 1216257 - Move "Language" settting to "General" section r=rnewman Bug 1216257 - Move "Language" settting to "General" section r=rnewman

Comment on attachment 8678973 [details] MozReview Request: Bug 1216257 - Move tap-to-load images pref from to "Advanced". r=sebastian Bug 1216257 - Move tap-to-load images pref from to "Advanced". r=sebastian

Comment on attachment 8678971 [details] MozReview Request: Bug 1216257 - Move clear private data setting to top level. r=sebastian Bug 1216257 - Move clear private data setting to top level. r=sebastian

Comment on attachment 8678974 [details] MozReview Request: Bug 1216257 - Move titlebar pref to "General". r=sebastian Bug 1216257 - Move titlebar pref to "General". r=sebastian

Comment on attachment 8678972 [details] MozReview Request: Bug 1216257 - Move restore tabs pref from to "Advanced". r=sebastian Bug 1216257 - Move restore tabs pref from to "Advanced". r=sebastian

Comment on attachment 8678975 [details] MozReview Request: Bug 1216257 - Move full-screen browsing pref to "General". r=sebastian Bug 1216257 - Move full-screen browsing pref to "General". r=sebastian

Comment on attachment 8678973 [details] MozReview Request: Bug 1216257 - Move tap-to-load images pref from to "Advanced". r=sebastian Bug 1216257 - Move tap-to-load images pref from to "Advanced". r=sebastian

Comment on attachment 8678976 [details] MozReview Request: Bug 1216257 - Rearrange search settings to match spec. r=sebastian Bug 1216257 - Rearrange search settings to match spec. r=sebastian

Comment on attachment 8678974 [details] MozReview Request: Bug 1216257 - Move titlebar pref to "General". r=sebastian Bug 1216257 - Move titlebar pref to "General". r=sebastian

Comment on attachment 8678977 [details] MozReview Request: Bug 1216257 - Rearrange privacy prefs to match spec. r=sebastian Bug 1216257 - Rearrange privacy prefs to match spec. r=sebastian

Comment on attachment 8678975 [details] MozReview Request: Bug 1216257 - Move full-screen browsing pref to "General". r=sebastian Bug 1216257 - Move full-screen browsing pref to "General". r=sebastian

Comment on attachment 8678978 [details] MozReview Request: Bug 1216257 - Move data reporting prefs to "Privacy". r=sebastian Bug 1216257 - Move data reporting prefs to "Privacy". r=sebastian

Comment on attachment 8678976 [details] MozReview Request: Bug 1216257 - Rearrange search settings to match spec. r=sebastian Bug 1216257 - Rearrange search settings to match spec. r=sebastian

Comment on attachment 8678979 [details] MozReview Request: Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r=sebastian Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r=sebastian

Comment on attachment 8678977 [details] MozReview Request: Bug 1216257 - Rearrange privacy prefs to match spec. r=sebastian Bug 1216257 - Rearrange privacy prefs to match spec. r=sebastian

Comment on attachment 8678980 [details] MozReview Request: Bug 1216257 - Remove disabled tests and associated strings. r=gbrown Bug 1216257 - Remove disabled tests and associated strings. r=gbrown

Comment on attachment 8678978 [details] MozReview Request: Bug 1216257 - Move data reporting prefs to "Privacy". r=sebastian Bug 1216257 - Move data reporting prefs to "Privacy". r=sebastian

Comment on attachment 8678979 [details] MozReview Request: Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r=sebastian Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r=sebastian

Comment on attachment 8678980 [details] MozReview Request: Bug 1216257 - Remove disabled tests and associated strings. r=gbrown Bug 1216257 - Remove disabled tests and associated strings. r=gbrown

Comment on attachment 8678970 [details] MozReview Request: Bug 1216257 - Move "Language" settting to "General" section r=rnewman https://reviewboard.mozilla.org/r/23299/#review21539

https://hg.mozilla.org/integration/fx-team/rev/a7e5e29700525351e0ed526ffe7f5b3adda7417b Bug 1216257 - Rename "Customize" category to "General" r=sebastian https://hg.mozilla.org/integration/fx-team/rev/d95025365c7bc9b242f4d99693b910da792c6171 Bug 1216257 - Move "Search" category to top level r=sebastian https://hg.mozilla.org/integration/fx-team/rev/c14c69c00c93bb3bcceeb94e4c2517f6d1af89ee Bug 1216257 - Rename "Display" category to "Accessibility" r=sebastian https://hg.mozilla.org/integration/fx-team/rev/311d614a4f3945b4ac30e418ba5060058f0f6855 Bug 1216257 - Rename "Developer Tools" category to "Advanced" r=sebastian https://hg.mozilla.org/integration/fx-team/rev/337a67f70d857d36a64387f585454010934690dc Bug 1216257 - Move "Language" settting to "General" section r=rnewman https://hg.mozilla.org/integration/fx-team/rev/fdc1692ee653210fb32c3853479e9f9e26d2bd8e Bug 1216257 - Move clear private data setting to top level. r=sebastian https://hg.mozilla.org/integration/fx-team/rev/0d0fbf8cc9846eb7e80f935fb3224b67ab5f2fe3 Bug 1216257 - Move restore tabs pref from to "Advanced". r=sebastian https://hg.mozilla.org/integration/fx-team/rev/b6b88bfc3e6fea6a0b1ee39f9bc2e3941f035c83 Bug 1216257 - Move tap-to-load images pref from to "Advanced". r=sebastian https://hg.mozilla.org/integration/fx-team/rev/bb0185d08c37ee7311eca0cb3cb7fd9bea9fdb6e Bug 1216257 - Move titlebar pref to "General". r=sebastian https://hg.mozilla.org/integration/fx-team/rev/9f452774df93aab94e145801acea3733440d826f Bug 1216257 - Move full-screen browsing pref to "General". r=sebastian https://hg.mozilla.org/integration/fx-team/rev/7b3d106493724deccb95693d6ae4dc0e003eb120 Bug 1216257 - Rearrange search settings to match spec. r=sebastian https://hg.mozilla.org/integration/fx-team/rev/7187870fbc9a8c36ec094e87ae4d503155acc291 Bug 1216257 - Rearrange privacy prefs to match spec. r=sebastian https://hg.mozilla.org/integration/fx-team/rev/464002006f1dc3f899fb8a8df3705212d040497e Bug 1216257 - Move data reporting prefs to "Privacy". r=sebastian https://hg.mozilla.org/integration/fx-team/rev/52b8491314efce1263eb6fa338ea333a63116452 Bug 1216257 - Move settings items that don't belong elsewhere to "Advanced". r=sebastian https://hg.mozilla.org/integration/fx-team/rev/a2fd04686fd78e86337bda329dd8668f96c08387 Bug 1216257 - Remove disabled tests and associated strings. r=gbrown

https://hg.mozilla.org/mozilla-central/rev/a7e5e2970052 https://hg.mozilla.org/mozilla-central/rev/d95025365c7b https://hg.mozilla.org/mozilla-central/rev/c14c69c00c93 https://hg.mozilla.org/mozilla-central/rev/311d614a4f39 https://hg.mozilla.org/mozilla-central/rev/337a67f70d85 https://hg.mozilla.org/mozilla-central/rev/fdc1692ee653 https://hg.mozilla.org/mozilla-central/rev/0d0fbf8cc984 https://hg.mozilla.org/mozilla-central/rev/b6b88bfc3e6f https://hg.mozilla.org/mozilla-central/rev/bb0185d08c37 https://hg.mozilla.org/mozilla-central/rev/9f452774df93 https://hg.mozilla.org/mozilla-central/rev/7b3d10649372 https://hg.mozilla.org/mozilla-central/rev/7187870fbc9a https://hg.mozilla.org/mozilla-central/rev/464002006f1d https://hg.mozilla.org/mozilla-central/rev/52b8491314ef https://hg.mozilla.org/mozilla-central/rev/a2fd04686fd7

Tested using Nexus 9 (Android 6.0) is it expected that on tablet "Import from Android" option is missing and "Clear Private data now" is under General submenu?

(In reply to Teodora Vermesan (:TeoVermesan) from comment #92) > Tested using Nexus 9 (Android 6.0) is it expected that on tablet "Import > from Android" option is missing and "Clear Private data now" is under > General submenu? Import from Android should be under Advanced... it's a bug if that's missing. Yes, I decided to put "Clear private data now" under General, to match what we do with the Sync sign-in option, but there was some discussion about whether or not that's the best solution, and looking back at the comments here, I don't actually see a consensus on this issue. Could you file bugs for these two issues and assign them to me?

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a7e5e2970052 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d95025365c7b https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/c14c69c00c93 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/311d614a4f39 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/337a67f70d85 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fdc1692ee653 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0d0fbf8cc984 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b6b88bfc3e6f https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/bb0185d08c37 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9f452774df93 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7b3d10649372 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7187870fbc9a https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/464002006f1d https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/52b8491314ef https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a2fd04686fd7

Is it expected that "Advanced" sub-menu is missing from Guest Mode Session? "Advanced" now has "import from android", "download updates automatically", "tabs", "tap-to-load images", "plugins", etc; options that were present in guest mode before this settings reorganization.

(In reply to Teodora Vermesan (:TeoVermesan) from comment #95) > Is it expected that "Advanced" sub-menu is missing from Guest Mode Session? > "Advanced" now has "import from android", "download updates automatically", > "tabs", "tap-to-load images", "plugins", etc; options that were present in > guest mode before this settings reorganization. I filed bug 1217073 about restricted profiles, but I don't have a bug explicitly filed about guest profiles. I imagine a lot of the work will be the same, but could you file a follow-up bug for me to remember to fix that? Good find, thanks!

Release Note Request (optional, but appreciated) [Why is this notable]:menu settings have changed/moved [Suggested wording]: Optimized & re-organized "Settings" under "Menu" [Links (documentation, blog post, etc)]:

Already in the release notes