KM Lee [:rexboy] (inactivate after Sep. 22) Assignee
	Description • 9 years ago

This bug should implement FTE for Home App.
Refer to UX:
https://drive.google.com/a/mozilla.com/folderview?id=0B5RN80W56Ga9fjlncXJuZW5YbW0zX2tDX0sta3FsMXU3cmRYM0hTOEJXZFZ2ck5wSW1PZlU&usp=sharing&tid=0B5RN80W56Ga9WkNBRlZmWUtiaU0

Visual: 
https://drive.google.com/a/mozilla.com/folderview?id=0B4K8q1qWmtAvdUJFYUx5NFBEaVk&usp=sharing&tid=0B2-G3kew1WpXLURNc29vTWl5eUk

	KM Lee [:rexboy] (inactivate after Sep. 22) Assignee
	Comment 2 • 9 years ago

Comment on attachment 8683032 [details]
[gaia] rexboy7:TV_FTE_Home > mozilla-b2g:master

Hi Yifan:
Are you available for review this patch? Please see Github comment for some detail. If you are busy I can try to find another reviewer.

Luke:
I made a small refactoring to SpatialNavigator (to replace focusSilently by a  "silent" property). Can you take a look on that small change?

Fischer:
The FTEWizard may be reusable for you so you may take a look to see if it's applicable in your work.

	yifan [:yifan][:yliao]
	Comment 3 • 9 years ago

Comment on attachment 8683032 [details]
[gaia] rexboy7:TV_FTE_Home > mozilla-b2g:master

LGTM! Just a couple comments on Github, thanks!

	Luke Chang [:lchang] (inactive)
	Comment 4 • 9 years ago

Comment on attachment 8683032 [details]
[gaia] rexboy7:TV_FTE_Home > mozilla-b2g:master

Looks good! Only a few nits left. Thanks.

	KM Lee [:rexboy] (inactivate after Sep. 22) Assignee
	Comment 5 • 9 years ago

master
https://github.com/mozilla-b2g/gaia/commit/f3de644ae536d33d9a1a9ac5a2e2f438c33154d8

	KM Lee [:rexboy] (inactivate after Sep. 22) Assignee
	Comment 6 • 9 years ago

Comment on attachment 8683032 [details]
[gaia] rexboy7:TV_FTE_Home > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: Absence of first-time use in Smart-home app
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): middle
[String changes made]: Yes

This is a subitem of blocker bug 1205944, so it should be a blocker.

	Mahendra Potharaju [:mahe]
	Comment 7 • 9 years ago

Josh, 

Can this land independent of other bugs in 1205944? Or wait until all others are complete?

	Josh Cheng [:josh]
	Comment 8 • 9 years ago

Hi Mahe,
This can be landed 2.5 independently. 
Partner will do l10n work for 2.5 TV so no need to add "late-l10n" keyword here. Thanks!

	Mahendra Potharaju [:mahe]
	Comment 9 • 9 years ago

Comment on attachment 8683032 [details]
[gaia] rexboy7:TV_FTE_Home > mozilla-b2g:master

Approved for 2.5 landing. 

Thank you

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago

2.5 -> https://github.com/mozilla-b2g/gaia/commit/9dc33b054d31bbe692777a6a340c6da85e512978