04:19:44 INFO - ##### Running taskcluster-upload step. 04:19:44 INFO - ##### 04:19:44 INFO - Running main action method: taskcluster_upload 04:19:44 FATAL - Uncaught exception: Traceback (most recent call last): 04:19:44 FATAL - File "/builds/slave/rel-m-beta-and-api-9_rpk_6-000/scripts/mozharness/base/script.py", line 1698, in run 04:19:44 FATAL - self.run_action(action) 04:19:44 FATAL - File "/builds/slave/rel-m-beta-and-api-9_rpk_6-000/scripts/mozharness/base/script.py", line 1640, in run_action 04:19:44 FATAL - self._possibly_run_method(method_name, error_if_missing=True) 04:19:44 FATAL - File "/builds/slave/rel-m-beta-and-api-9_rpk_6-000/scripts/mozharness/base/script.py", line 1581, in _possibly_run_method 04:19:44 FATAL - return getattr(self, method_name)() 04:19:44 FATAL - File "scripts/scripts/mobile_l10n.py", line 485, in taskcluster_upload 04:19:44 FATAL - branch = self.config['branch'] 04:19:44 FATAL - KeyError: 'branch'

do we need TC uploads for these?

(In reply to Chris AtLee [:catlee] from comment #1) > do we need TC uploads for these? looks like mobile_l10n.py got and the nightly single_locale configs but not the release equivalents. I don't think it will be much to get them working. patch incoming. will remove taskcluster-upload action if this fails

need to upload this to beta. I'm going to put a=testing if r+'d

nick saw that we are also failing to upload. since we have more than one thing failing, let's disable the taskcluster submission altogether and fix uploads by passing the UPLOAD_* vars needed

Comment on attachment 8682319 [details] [diff] [review] 151102_1220765_fennec_tc_upload_beta_release_config_fix-bbot-cfgs.patch Looks good. When you get a few spare minutes please add a patch for the release case to the appropriate tracking/merge bug so we don't have a rerun in 5 weeks.

Jordan already did that on bug 1220964, because he is awesome.

Comment on attachment 8682319 [details] [diff] [review] 151102_1220765_fennec_tc_upload_beta_release_config_fix-bbot-cfgs.patch thanks! https://hg.mozilla.org/build/buildbot-configs/rev/93b4a92d47ec needs a push to prod + reconfig

Pushed to prod https://hg.mozilla.org/build/buildbot-configs/rev/2bbee0121da5

(In reply to Jordan Lund (:jlund) from comment #7) > Comment on attachment 8682319 [details] [diff] [review] > 151102_1220765_fennec_tc_upload_beta_release_config_fix-bbot-cfgs.patch > > thanks! https://hg.mozilla.org/build/buildbot-configs/rev/93b4a92d47ec > > needs a push to prod + reconfig looks like this worked. however we have more uplift issues. at the very least, we need to put 'stage_product' in the config

so unfortunately we are trying to interpolate stage_product in POST_UPLOAD_CMD: * https://hg.mozilla.org/releases/mozilla-beta/file/fcf963bf85da/testing/mozharness/configs/single_locale/production.py#l9 * https://hg.mozilla.org/releases/mozilla-beta/file/fcf963bf85da/testing/mozharness/scripts/mobile_l10n.py#l190 I say unfortunate bc we just override it anyway a few lines down: * https://hg.mozilla.org/releases/mozilla-beta/file/fcf963bf85da/testing/mozharness/scripts/mobile_l10n.py#l550 I guess we can add stage_product into the release configs

In production: https://hg.mozilla.org/build/buildbot-configs/rev/93b4a92d47ec

I think we are good here now :)