Post 1220891, no native Firefox Account UI will be shipping. We should kill this code, saving both compile time, classes.dex bytes, and resource space.

(In reply to Nick Alexander :nalexander from comment #0) > Post 1220891 Not armageddon: Bug 1120891. This should be tracking Fennec 45 or 46.

(In reply to Nick Alexander :nalexander from comment #1) > (In reply to Nick Alexander :nalexander from comment #0) > > Post 1220891 > > Not armageddon: Bug 1120891. This should be tracking Fennec 45 or 46. Heh, my typing is terrible: Bug 1220891.

Bug 1220892 - Part 1: Remove MOZ_ANDROID_NATIVE_ACCOUNTS_UI. r?mcomella

Bug 1220892 - Part 2: Remove Activity sub-classes. r?mcomella

Bug 1220892 - Part 3: Remove Task sub-classes. r?mcomella

Bug 1220892 - Part 4: Clean up FxAccountAbstractSetupActivity. r?mcomella The web based Activity sub-classes never used the other intent extras, and in fact, filter them out immediately; so it doesn't hurt to clean this all up.

Bug 1220892 - Part 5: Remove FxAccountAgeLockoutHelper. r?mcomella

Bug 1220892 - Bug 1220892 - Part 6: Remove non-string resources. r?mcomella I'm reluctant to mass-delete strings, since that could cause our l10n team some grief in the event of a rollback. And it's not obviously easy to get them all back smoothly. I'll delete strings separately.

Comment on attachment 8694497 [details] MozReview Request: Bug 1220892 - Part 1: Remove MOZ_ANDROID_NATIVE_ACCOUNTS_UI. r?mcomella https://reviewboard.mozilla.org/r/26791/#review24341 ::: mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountStatusFragment.java:236 (Diff revision 1) > + return true; It looks like before we didn't return here and probably return false at the end of the function – was that a mistake? Is that why we're returning true here?

Comment on attachment 8694498 [details] MozReview Request: Bug 1220892 - Part 2: Remove Activity sub-classes. r?mcomella https://reviewboard.mozilla.org/r/26793/#review24345 Didn't connect all the dots to make sure this code will compile but if it works for you, it works for me. ::: mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountAbstractSetupActivity.java:81 (Diff revision 1) > - super(CANNOT_RESUME_WHEN_ACCOUNTS_EXIST | CANNOT_RESUME_WHEN_LOCKED_OUT); > + super(CANNOT_RESUME_WHEN_ACCOUNTS_EXIST); I assume the online interface handles lock out now?

Comment on attachment 8694499 [details] MozReview Request: Bug 1220892 - Part 3: Remove Task sub-classes. r?mcomella https://reviewboard.mozilla.org/r/26795/#review24349

Comment on attachment 8694500 [details] MozReview Request: Bug 1220892 - Part 4: Clean up FxAccountAbstractSetupActivity. r?mcomella https://reviewboard.mozilla.org/r/26797/#review24351

Comment on attachment 8694501 [details] MozReview Request: Bug 1220892 - Part 5: Remove FxAccountAgeLockoutHelper. r?mcomella https://reviewboard.mozilla.org/r/26799/#review24353

Comment on attachment 8694502 [details] MozReview Request: Bug 1220892 - Bug 1220892 - Part 6: Remove non-string resources. r?mcomella https://reviewboard.mozilla.org/r/26801/#review24355 I'd be curious to see the APK-size improvements after this patch. :)

https://reviewboard.mozilla.org/r/26793/#review24345 > I assume the online interface handles lock out now? This file dies entirely in Part 4, but you are correct: `fxa-content-server` handles any COPPA lock out.

https://reviewboard.mozilla.org/r/26801/#review24355 Locally, I saw about 100kb. Not a ton, but considering that it's mostly code and before Proguard, not bad. I'm pleased to remove a lot of untested UI code.

https://hg.mozilla.org/integration/fx-team/rev/5e790a98e114de8259ae7ed10aee17b66028acfb Bug 1220892 - Part 1: Remove MOZ_ANDROID_NATIVE_ACCOUNTS_UI. r=mcomella https://hg.mozilla.org/integration/fx-team/rev/d2be8686105daf21da88db6bf163bad2eba0c3e2 Bug 1220892 - Part 2: Remove Activity sub-classes. r=mcomella https://hg.mozilla.org/integration/fx-team/rev/61f2a1360c6d2556ada47b4dc68eeec16f7919b4 Bug 1220892 - Part 3: Remove Task sub-classes. r=mcomella https://hg.mozilla.org/integration/fx-team/rev/f659e1c2d182ae4194d5a57706e106d4ec6a4a35 Bug 1220892 - Part 4: Clean up FxAccountAbstractSetupActivity. r=mcomella https://hg.mozilla.org/integration/fx-team/rev/62e4fa9f1000018cf278361853a461de38b61df5 Bug 1220892 - Part 5: Remove FxAccountAgeLockoutHelper. r=mcomella https://hg.mozilla.org/integration/fx-team/rev/675689351241e48a85bf474ee08a6bc75787027b Bug 1220892 - Part 6: Remove non-string resources. r=mcomella

(In reply to Michael Comella (:mcomella) from comment #16) > I'd be curious to see the APK-size improvements after this patch. :) (In reply to Nick Alexander :nalexander from comment #18) > Locally, I saw about 100kb. Not a ton, but considering that it's mostly > code and before Proguard, not bad. I'm pleased to remove a lot of untested > UI code. 116KB decrease in APK size. 76KB from classes.dex Nice!

https://hg.mozilla.org/mozilla-central/rev/5e790a98e114 https://hg.mozilla.org/mozilla-central/rev/d2be8686105d https://hg.mozilla.org/mozilla-central/rev/61f2a1360c6d https://hg.mozilla.org/mozilla-central/rev/f659e1c2d182 https://hg.mozilla.org/mozilla-central/rev/62e4fa9f1000 https://hg.mozilla.org/mozilla-central/rev/675689351241