Closed
Bug 1375933
Opened 7 years ago
Closed 4 years ago
Move NativeCrypto out of "services" and into Fennec proper
Categories
(Firefox for Android Graveyard :: Firefox Accounts, enhancement)
Firefox for Android Graveyard
Firefox Accounts
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: nalexander, Unassigned)
References
Details
http://searchfox.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/background/nativecode/NativeCrypto.java started as an interface for native code, shipped in libmozglue.so, to be accessed by the Android Background Services -- in particular, for a fast pbkdf2 implementation for the Firefox Accounts implementation. However, that native implementation is vestigial -- we use a web interface now which does all the pbkdf2 crypto on the fxa-content-server. The remaining consumers of NativeCrypto can be removed as follow-ups to Bug 1229892 or moved into the main Fennec codebase. At that point, NativeCrypto can move to the existing JNI wrappers scheme (@WrapForJNI), and the services code can drop the dependency on libmozglue.
That will help making "services" a seperate Gradle project (Bug 1229149) and might help projects like https://github.com/mozilla-mobile/FirefoxData-android move back in-tree.
Reporter | ||
Comment 1•7 years ago
|
||
mcomella, liuche: I think you two are the most knowledgable about FirefoxData-android. NI to you just so you're aware of this, and for one of you to explain what you did in that project around dropping the NativeCrypto dependency.
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(liuche)
Reporter | ||
Updated•7 years ago
|
Summary: Move NativeCrypto → Move NativeCrypto out of "services" and into Fennec proper
Comment 2•7 years ago
|
||
I worked on the android version (liuche is doing iOS). wrt NativeCrypto, to reduce the method counts of the library, I removed it because it was unused. I started by removing a lot of top-level unused code including the imported fennec dependencies which eventually led to the removal of NativeCrypto.
Leave liuche CC for awareness but no action required.
Flags: needinfo?(michael.l.comella)
Updated•7 years ago
|
Flags: needinfo?(liuche)
Comment 3•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•