Closed
Bug 1222548
Opened 9 years ago
Closed 9 years ago
Allow passing a relative directory to --source
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jlund
:
review+
|
Details | Diff | Splinter Review |
I have had two different people attempt to use the spidermonkey_build.py script now and run afoul of this.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8684362 -
Flags: review?(jlund)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8684362 [details] [diff] [review]
Allow passing a relative directory to --source
Review of attachment 8684362 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm.
do we need self.config['srcdir'] at all? or can we just do the following in pre_config_lock:
`self.config['source'] = os.path.abspath(self.config['source'])`?
and then always reference self.config['source'] whether it gets its value from a cfg file or overrided by cmd line --source?
Attachment #8684362 -
Flags: review?(jlund) → review+
|
|
||
Comment 3•9 years ago
|
||
again sorry for delays. b2g 2.5 release took all my time this week.
|
|
Assignee | |
Comment 4•9 years ago
|
||
I'm not really using this script for anything anymore. I've switched to shell scripts under TC. And if I switch back to python, I'm unlikely to reuse this script.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•