The tests have a very high failure rate on these platforms and I don't believe there are any plans to fix them.

Syd, if there are any objections from the media team, please let us know.

There is agreement to disable for Linux ASAN, and debug, but PGO should work. Media team will investigate PGO builds.

(In reply to Syd Polk :sydpolk from comment #2) > There is agreement to disable for Linux ASAN, and debug, but PGO should > work. Media team will investigate PGO builds. Thanks, Syd. I'll get buildduty to disable the media-tests for the ASAN/debug variants.

Comment on attachment 8686054 [details] [diff] [review] bug_1223072.patch Where did you get the list of branches for BRANCHES_TEMP for development and release-stabilization branches? Usually we specify branches by looking at a gecko_version and enabling or disabling based on that so as the list of branches is modified as the gecko version increases

Comment on attachment 8686054 [details] [diff] [review] bug_1223072.patch please use a different variable name than BRANCHES_TEMP that is more descriptive and is not capitalized In the comment, "# Disable media-tests on development and release-stabilization branches (bug 1223072)" start with # bug 1223072 as this is the convention in the rest of the file

Updated the patch. The diff file is the same.

Comment on attachment 8686526 [details] [diff] [review] bug_1223072.patch Review of attachment 8686526 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks good. r+ with the requested change. ::: mozilla-tests/config.py @@ +2514,5 @@ > branch['platforms'][platform][slave_platform]['opt_unittest_suites'] += MEDIATESTS > branch['platforms'][platform][slave_platform]['debug_unittest_suites'] += MEDIATESTS > > +# Bug 1223072 - disable media-tests on linux asan, debug (on development and release-stabilization branches) > +dev_releasestab_branches = ('b2g-inbound', 'fx-team', 'mozilla-central', 'mozilla-inbound', 'mozilla-b2g37_v2_2', 'mozilla-beta', 'mozilla-esr38', 'mozilla-release', 'mozilla-aurora') Can we split this into two separate lists -- one for dev branches and one for release -- and then join them afterwards? This will make it easier to update either in the future.

updated the patch

Uploaded the current version of the patch. Tested it on my test master, the builder diff file is the same.

Comment on attachment 8689528 [details] [diff] [review] bug1223072.patch Review of attachment 8689528 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla-tests/config.py @@ +2516,5 @@ > > + > +# Bug 1223072 - disable media-tests on linux asan, debug (on development and release-stabilization branches) > +development_branches = ('b2g-inbound', 'fx-team', 'mozilla-central', 'mozilla-inbound') > +release_stab_branches = ('mozilla-b2g37_v2_2', 'mozilla-beta', 'mozilla-esr38', 'mozilla-release', 'mozilla-aurora') "release_stab_branches" still makes me smile.

Comment on attachment 8689528 [details] [diff] [review] bug1223072.patch Review of attachment 8689528 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/build/buildbot-configs/rev/91edb875118e

In production: https://hg.mozilla.org/build/buildbot-configs/rev/91edb875118e

Wups, I should have done more than just chuckle at release_stab_branches, I should have looked at why it was getting defined. What Maja meant by "development and release-stabilization branches" was "everywhere," rather than "everywhere except for twigs and try." The key part was "I don't believe there are any plans to fix them" as in nobody is going to ever look at them anywhere, there is no point in running them anywhere.

Okay, that makes things easier :) Uploaded the new patch.

In production: https://hg.mozilla.org/build/buildbot-configs/rev/44127b43f6b1