Closed
Bug 1223072
Opened 9 years ago
Closed 9 years ago
disable media-tests on linux asan, debug (on development and release-stabilization branches)
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox45 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox45 | --- | affected |
People
(Reporter: impossibus, Assigned: aselagea)
References
Details
Attachments
(3 files, 3 obsolete files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
coop
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kmoir
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
The tests have a very high failure rate on these platforms and I don't believe there are any plans to fix them.
Reporter | ||
Comment 1•9 years ago
|
||
Syd, if there are any objections from the media team, please let us know.
Flags: needinfo?(spolk)
Updated•9 years ago
|
status-firefox45:
--- → affected
Comment 2•9 years ago
|
||
There is agreement to disable for Linux ASAN, and debug, but PGO should work. Media team will investigate PGO builds.
Updated•9 years ago
|
Flags: needinfo?(spolk)
Reporter | ||
Updated•9 years ago
|
Summary: disable media-tests on linux asan, debug, pgo (on development and release-stabilization branches) → disable media-tests on linux asan, debug (on development and release-stabilization branches)
Comment 3•9 years ago
|
||
(In reply to Syd Polk :sydpolk from comment #2)
> There is agreement to disable for Linux ASAN, and debug, but PGO should
> work. Media team will investigate PGO builds.
Thanks, Syd. I'll get buildduty to disable the media-tests for the ASAN/debug variants.
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8686054 -
Flags: review?(kmoir)
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → alin.selagea
Comment 6•9 years ago
|
||
Comment on attachment 8686054 [details] [diff] [review]
bug_1223072.patch
Where did you get the list of branches for BRANCHES_TEMP for development and release-stabilization branches? Usually we specify branches by looking at a gecko_version and enabling or disabling based on that so as the list of branches is modified as the gecko version increases
Comment 7•9 years ago
|
||
Comment on attachment 8686054 [details] [diff] [review]
bug_1223072.patch
please use a different variable name than BRANCHES_TEMP that is more descriptive and is not capitalized
In the comment, "# Disable media-tests on development and release-stabilization branches (bug 1223072)"
start with # bug 1223072 as this is the convention in the rest of the file
Assignee | ||
Comment 8•9 years ago
|
||
Updated the patch. The diff file is the same.
Attachment #8686054 -
Attachment is obsolete: true
Attachment #8686054 -
Flags: review?(kmoir)
Attachment #8686526 -
Flags: review?(kmoir)
Comment 9•9 years ago
|
||
Comment on attachment 8686526 [details] [diff] [review]
bug_1223072.patch
Review of attachment 8686526 [details] [diff] [review]:
-----------------------------------------------------------------
Patch looks good. r+ with the requested change.
::: mozilla-tests/config.py
@@ +2514,5 @@
> branch['platforms'][platform][slave_platform]['opt_unittest_suites'] += MEDIATESTS
> branch['platforms'][platform][slave_platform]['debug_unittest_suites'] += MEDIATESTS
>
> +# Bug 1223072 - disable media-tests on linux asan, debug (on development and release-stabilization branches)
> +dev_releasestab_branches = ('b2g-inbound', 'fx-team', 'mozilla-central', 'mozilla-inbound', 'mozilla-b2g37_v2_2', 'mozilla-beta', 'mozilla-esr38', 'mozilla-release', 'mozilla-aurora')
Can we split this into two separate lists -- one for dev branches and one for release -- and then join them afterwards? This will make it easier to update either in the future.
Attachment #8686526 -
Flags: review?(kmoir) → review+
Assignee | ||
Comment 10•9 years ago
|
||
updated the patch
Attachment #8686526 -
Attachment is obsolete: true
Attachment #8687084 -
Flags: feedback?(coop)
Updated•9 years ago
|
Attachment #8687084 -
Flags: feedback?(coop) → feedback+
Assignee | ||
Comment 11•9 years ago
|
||
Uploaded the current version of the patch. Tested it on my test master, the builder diff file is the same.
Attachment #8687084 -
Attachment is obsolete: true
Attachment #8689528 -
Flags: review?(coop)
Comment 12•9 years ago
|
||
Comment on attachment 8689528 [details] [diff] [review]
bug1223072.patch
Review of attachment 8689528 [details] [diff] [review]:
-----------------------------------------------------------------
::: mozilla-tests/config.py
@@ +2516,5 @@
>
> +
> +# Bug 1223072 - disable media-tests on linux asan, debug (on development and release-stabilization branches)
> +development_branches = ('b2g-inbound', 'fx-team', 'mozilla-central', 'mozilla-inbound')
> +release_stab_branches = ('mozilla-b2g37_v2_2', 'mozilla-beta', 'mozilla-esr38', 'mozilla-release', 'mozilla-aurora')
"release_stab_branches" still makes me smile.
Attachment #8689528 -
Flags: review?(coop) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8689528 [details] [diff] [review]
bug1223072.patch
Review of attachment 8689528 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/build/buildbot-configs/rev/91edb875118e
Attachment #8689528 -
Flags: checked-in+
Comment 14•9 years ago
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 15•9 years ago
|
||
Wups, I should have done more than just chuckle at release_stab_branches, I should have looked at why it was getting defined.
What Maja meant by "development and release-stabilization branches" was "everywhere," rather than "everywhere except for twigs and try." The key part was "I don't believe there are any plans to fix them" as in nobody is going to ever look at them anywhere, there is no point in running them anywhere.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 16•9 years ago
|
||
Okay, that makes things easier :)
Uploaded the new patch.
Attachment #8697974 -
Flags: review?(kmoir)
Updated•9 years ago
|
Attachment #8697974 -
Flags: review?(kmoir) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8697974 -
Flags: checked-in?
Assignee | ||
Updated•9 years ago
|
Attachment #8697974 -
Flags: checked-in? → checked-in+
Assignee | ||
Comment 17•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•