Closed Bug 1224013 Opened 9 years ago Closed 9 years ago

Render text emphasis marks outside ruby

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 2 open bugs, )

Details

Attachments

(4 files)

I'd like to separate this issue to an independent bug, because there is an unsolved question on this behavior, see: https://lists.w3.org/Archives/Public/www-style/2015Nov/0193.html Depending on the answer there, the implementation could be easy or super complicated that we may only want an imperfect impl.
Bug 1224013 part 1 - Enable text-emphasis in UA sheets. The only usage of text-emphasis in UA sheets is to clear it on ruby text. Making it enabled in UA sheets allows that rule to take effect without additional code to reload html.css when the pref changes.
Attachment #8694160 - Flags: review?(dbaron)
Bug 1224013 part 2 - Move leading fix to ruby base container. Per spec, the additional leading is added on side of ruby base container, not ruby container. This could lead to some trivial behavior changes on edge cases.
Attachment #8694161 - Flags: review?(dholbert)
Bug 1224013 part 3 - Render text-emphasis outside ruby.
Attachment #8694162 - Flags: review?(jfkthame)
Bug 1224013 part 4 - Add reftests for text-emphasis with ruby.
Attachment #8694163 - Flags: review?(jfkthame)
Comment on attachment 8694160 [details] MozReview Request: Bug 1224013 part 1 - Enable text-emphasis in UA sheets. https://reviewboard.mozilla.org/r/26667/#review24207 It might be worth putting a note on the bug to enable these properties that you can remove these flags when you remove the pref. (If there's not a bug to enable them already, there should be... with bugs blocking it.)
Attachment #8694160 - Flags: review?(dbaron) → review+
Blocks: 1229609
Comment on attachment 8694161 [details] MozReview Request: Bug 1224013 part 2 - Move leading fix to ruby base container. https://reviewboard.mozilla.org/r/26669/#review24409
Attachment #8694161 - Flags: review?(dholbert) → review+
Comment on attachment 8694162 [details] MozReview Request: Bug 1224013 part 3 - Render text-emphasis outside ruby. https://reviewboard.mozilla.org/r/26671/#review24429
Attachment #8694162 - Flags: review?(jfkthame) → review+
Comment on attachment 8694163 [details] MozReview Request: Bug 1224013 part 4 - Add reftests for text-emphasis with ruby. https://reviewboard.mozilla.org/r/26673/#review24431
Attachment #8694163 - Flags: review?(jfkthame) → review+
Assignee: nobody → quanxunzhen
So part 2 breaks the reftests because when the ruby base container is placed, its required leadings have not been figured out. I'm going to land the patches except part 2 (also change part 3 to find nearest ruby frame instead of ruby base container).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: