Closed
Bug 1229609
Opened 9 years ago
Closed 8 years ago
Remove layout.css.text-emphasis.enabled pref
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
I don't think we need to follow the general "enable the feature by default" then long later "remove the pref" path, because:
1. this feature is not that complicated so I don't think it would cause any major breakage which would require us to switch it off again;
2. the spec around this feature has been quite stable for a while: some other vendors have been shipping a compitable prefixed version of this feature, and I don't see any major blocker during implementing it.
Given this, I believe we can simply remove the pref to enable it directly.
Updated•9 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 2•9 years ago
|
||
One correction: Blink is shipping a mostly compatible prefixed version (whose syntax of text-emphasis-position doesn't match the current spec), and WebKit is shipping a compatible unprefixed version.
Those impls haven't yet had the proper behavior for ruby with emphasis marks, though.
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1229609 - Remove layout.css.text-emphasis.enabled pref.
Attachment #8696528 -
Flags: review?(dbaron)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(dbaron)
Assignee | ||
Comment 4•9 years ago
|
||
dbaron, could you review this super simple patch?
Flags: needinfo?(dbaron)
Assignee | ||
Comment 5•9 years ago
|
||
As we've missed Firefox 45 for enabling text-emphasis, let's wait for the next version to remove the pref.
Flags: needinfo?(dbaron)
Assignee | ||
Updated•9 years ago
|
Attachment #8696528 -
Flags: review?(dbaron)
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8696528 [details]
MozReview Request: Bug 1229609 - Remove layout.css.text-emphasis.enabled pref.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27359/diff/1-2/
Attachment #8696528 -
Flags: review?(cam)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → quanxunzhen
Updated•9 years ago
|
Attachment #8696528 -
Flags: review?(cam)
Comment 8•9 years ago
|
||
Comment on attachment 8696528 [details]
MozReview Request: Bug 1229609 - Remove layout.css.text-emphasis.enabled pref.
https://reviewboard.mozilla.org/r/27359/#review41941
I think we should wait at least one cycle with the pref enabled on Release (46) before removing the pref.
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8696528 [details]
MozReview Request: Bug 1229609 - Remove layout.css.text-emphasis.enabled pref.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27359/diff/2-3/
Attachment #8696528 -
Flags: review?(cam)
Updated•8 years ago
|
Attachment #8696528 -
Flags: review?(cam) → review+
Comment 10•8 years ago
|
||
Comment on attachment 8696528 [details]
MozReview Request: Bug 1229609 - Remove layout.css.text-emphasis.enabled pref.
https://reviewboard.mozilla.org/r/27359/#review52798
Assignee | ||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03bd76ec05cb9b0765e79ab5077a61a533b40168
Bug 1229609 - Remove layout.css.text-emphasis.enabled pref. r=heycam
Comment 12•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 13•8 years ago
|
||
I added a comment in:
https://developer.mozilla.org/en-US/docs/Web/CSS/text-emphasis#Browser_compatibility
and in:
https://developer.mozilla.org/en-US/Firefox/Releases/49#CSS
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•