Closed
Bug 1224430
Opened 9 years ago
Closed 9 years ago
Revise browser FTE page style
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)
Tracking
(feature-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
feature-b2g | 2.5+ |
People
(Reporter: yifan, Assigned: danhuang)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
yifan
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details |
1. Center the sync diagram in the browser FTE page 2. Focused buttons in the FTE page gets too big.
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Updated•9 years ago
|
QA Whiteboard: [COM=TV::FTU]
Reporter | ||
Comment 2•9 years ago
|
||
Please also follow the instructions in https://bugzilla.mozilla.org/show_bug.cgi?id=1220581#c9 to compress the images, thanks!
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Flags: needinfo?(dhuang)
Comment 3•9 years ago
|
||
Please follow the visual guideline for Focused buttons. It's normal that you select right button, and the left button may covered by the right one. Thanks
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8689996 [details] [gaia] danhuang1202:1224430_revise_browser_fte_page > mozilla-b2g:master Hi Yifan, please help review. This patch update FTE page's image and button style base on the spec v0.5(https://drive.google.com/a/mozilla.com/folderview?id=0B4K8q1qWmtAvdUJFYUx5NFBEaVk). Thanks.
Attachment #8689996 -
Flags: review?(yliao)
Updated•9 years ago
|
QA Whiteboard: [COM=TV::FTU] → [COM=TV FTU]
Reporter | ||
Updated•9 years ago
|
Attachment #8689996 -
Flags: review?(yliao) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Thanks for the review. Merge in master: https://github.com/mozilla-b2g/gaia/commit/a70530c2b6c6c01b7d7745978f12426810cd9f1c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8689996 [details] [gaia] danhuang1202:1224430_revise_browser_fte_page > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Not align to UX visual spec [Testing completed]:https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=76c4716711c5f6c7b436231ebec825941fcaf62a [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8689996 -
Flags: approval-gaia-v2.5?
Assignee | ||
Updated•9 years ago
|
Attachment #8689996 -
Flags: approval-gaia-v2.5?
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8689996 [details] [gaia] danhuang1202:1224430_revise_browser_fte_page > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1199525 [User impact] if declined: Not align to UX visual spec [Testing completed]:https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=76c4716711c5f6c7b436231ebec825941fcaf62a [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8689996 -
Flags: approval-gaia-v2.5?
Comment 9•9 years ago
|
||
Comment on attachment 8689996 [details]
[gaia] danhuang1202:1224430_revise_browser_fte_page > mozilla-b2g:master
Approve for TV browser FTE
Attachment #8689996 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Updated•9 years ago
|
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
Comment 10•9 years ago
|
||
conflicts while uplifting -> Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 76c4716711c5f6c7b436231ebec825941fcaf62a error: could not apply 76c4716... Bug 1224430 - Revise browser FTE page style. r=yifan hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit'
Flags: needinfo?(dhuang)
Assignee | ||
Comment 11•9 years ago
|
||
I tried to cherry-pick 76c4716711c5f6c7b436231ebec825941fcaf62a in the branch v2.5, but there is no conflict occur. Please try to cherry-pick again. Thanks.
Flags: needinfo?(dhuang)
Comment 12•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/b061f46a3e27b3065e429b83278084f6135a50b1
Comment 13•8 years ago
|
||
This issue is verified on v2.5 and v2.6 latest build. [Build Info] 2.6 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08 gecko: https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26 2.5 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•