KM Lee [:rexboy] (inactivate after Sep. 22) Reporter
	Description • 9 years ago

+++ This bug was initially created as a clone of Bug #1220576 +++

This bug should implement FTE for Browser App.
Refer to UX:
https://drive.google.com/a/mozilla.com/folderview?id=0B5RN80W56Ga9fjlncXJuZW5YbW0zX2tDX0sta3FsMXU3cmRYM0hTOEJXZFZ2ck5wSW1PZlU&usp=sharing&tid=0B5RN80W56Ga9WkNBRlZmWUtiaU0

Visual: 
https://drive.google.com/a/mozilla.com/folderview?id=0B4K8q1qWmtAvdUJFYUx5NFBEaVk&usp=sharing&tid=0B2-G3kew1WpXLURNc29vTWl5eUk

	Josh Cheng [:josh]
	Comment 1 • 9 years ago

Hi YiFan,
Could you provide an ETA date? Thanks

	yifan [:yifan][:yliao] Assignee
	Comment 2 • 9 years ago

11/12

Hi Tori, the image below has redundant blanks. I'm not sure who can help on this one. https://lh6.googleusercontent.com/3K8GZHrbLHWTqEwSP5q_BmHLarjk3NvN02MoCnxAjt_7Y_Leg-04IOLiP4o3GofzM05CjQ=w1896-h831

	Tori Chen [:tori]
	Comment 3 • 9 years ago

Hi Peko, could you help on this? Thanks!

	KM Lee [:rexboy] (inactivate after Sep. 22) Reporter
	Comment 5 • 9 years ago

Comment on attachment 8686968 [details]
[gaia] begeeben:1220581_fte_for_browser > mozilla-b2g:master

Looks good to me with one comment.
Thanks !

	Peko Chen [:pekochen]
	Comment 6 • 9 years ago

Please see the link as below for FTE design
https://drive.google.com/open?id=0B4K8q1qWmtAvWFl1VVpjcWZUUUE
Thanks

	yifan [:yifan][:yliao] Assignee
	Comment 7 • 9 years ago

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/bd3c9a3861db14295c38b714bd4aafa234445b20

	yifan [:yifan][:yliao] Assignee
	Comment 8 • 9 years ago

Comment on attachment 8686968 [details]
[gaia] begeeben:1220581_fte_for_browser > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: No first time experience to guide a user
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=53bb0e37627af031c4070ab3b970f56323037f00
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: yes

	Gabriele Svelto [:gsvelto]
	Comment 9 • 9 years ago

I've noticed that two new images landed in this bug and it seems like they weren't recompressed before landing. Please use the recompression script available in gaia, this can be done by calling the following command in gaia top-most directory:

./tools/png_recompress.sh -v \
    tv_apps/browser/style/images/account_image.png \
    tv_apps/browser/style/images/firefox_logo.png

This will cut the image size almost in half. Note that you will need the optipng and advpng/advancecomp tools installed.

	yifan [:yifan][:yliao] Assignee
	Comment 10 • 9 years ago

Thank for the tip Gabriele! Since one of the images is not aligned to visual spec and we have to change it, we'll recompress them in bug 1224430 .

	Josh Cheng [:josh]
	Comment 11 • 9 years ago

Comment on attachment 8686968 [details]
[gaia] begeeben:1220581_fte_for_browser > mozilla-b2g:master

Approve as this is required for TV 2.5 FTU

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago

https://github.com/mozilla-b2g/gaia/commit/57ed2d2825131c7ef3aa5fad2c72937d5d85ee67 for 2.5

	yifan [:yifan][:yliao] Assignee
	Comment 13 • 9 years ago

The uplifted commit in the comment 12 https://bugzilla.mozilla.org/show_bug.cgi?id=1220581#c12 is not the patch for this bug.

	Carsten Book [:Tomcat]
	Comment 14 • 9 years ago

(In reply to yifan [:yifan][:yliao] from comment #13)
> The uplifted commit in the comment 12
> https://bugzilla.mozilla.org/show_bug.cgi?id=1220581#c12 is not the patch
> for this bug.

sorry https://github.com/mozilla-b2g/gaia/commit/07462becf08f0c26ebd64daf89646e7403a336c5 is the right one