Closed Bug 1228301 Opened 9 years ago Closed 9 years ago

[TV][2.5] This code segment is totally unreadable.

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1234163

People

(Reporter: jj.evelyn, Assigned: rexboy)

Details

(Whiteboard: [ft:conndevices])

in <gaia>/tv_apps/app-deck/js/context_menu.js, the following code is real hard to understand. We should rewrite it! 194 if (detail.removable === false) { 195 this.contextMenuElem.removeChild(this.removeElem); 196 } else { 197 this.contextMenuElem.insertBefore(this.removeElem, 198 this.pinToHomeElem.nextElementSibling); 199 } The intention here is to manipulate ContextMenu items, so when the app is removable, show 'pin to home' and 'uninstall' options on the menu. Otherwise, just show 'pin to home' option.
Whiteboard: [ft:conndevices]
Rewritten in bug 1234163.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.