Similar to Bug 1217771, a user is able to pin a website from app deck to smark-home. Therefore, instead of calling app.launch(), smart-home needs to use window.open() to open the website in a chrome-less window.

(In reply to Evelyn Hung [:evelyn] from comment #0) > Similar to Bug 1217771, a user is able to pin a website from app deck to > smark-home. Therefore, instead of calling app.launch(), smart-home needs to > use window.open() to open the website in a chrome-less window. or, opening the website in browser app and hide chrome ui is another feasible solution.

We'll use window.open() with remote=true to open bookmarks.

Comment on attachment 8701779 [details] [gaia] rexboy7:1234163-pin-bookmark-to-home > mozilla-b2g:master To support bookmark, lots of things changed. Luke may you do this review? You can just ask me on anything. And this pull request includes two commits, one for bug 1233677: make bookmark removable. But in this bug, I removed some changes that I made in 1233677. So I guess checking the whole pull request can prevent reviewing some "temporary" code.

Comment on attachment 8701779 [details] [gaia] rexboy7:1234163-pin-bookmark-to-home > mozilla-b2g:master Looks good! Only a few comments left on GitHub. Please have a look before landing. Thanks.

committed. https://github.com/mozilla-b2g/gaia/commit/30638896f176d22ffb6e9363aa7582d6ccd0fc8a

Comment on attachment 8701779 [details] [gaia] rexboy7:1234163-pin-bookmark-to-home > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): feature [User impact] if declined: not able to pin bookmarks to home [Testing completed]: done in local [Risk to taking this patch] (and alternatives if risky): medium [String changes made]: none

Comment on attachment 8701779 [details] [gaia] rexboy7:1234163-pin-bookmark-to-home > mozilla-b2g:master Approved for TV 2.5

has problems to apply to 2.5 Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick a035436497247aef9027474937f1c40cd87b2de7 error: could not apply a035436... Bug 1234163 - [TV][Stingray]Pin webpage bookmark from appdeck to home hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' could you provide a 2.5 PR request ? Thanks!

2.5: https://github.com/mozilla-b2g/gaia/commit/15a55112665aa24f9329629fe3ce5ca458b1c9da

(In reply to KM Lee [:rexboy] from comment #13) > 2.5: > https://github.com/mozilla-b2g/gaia/commit/ > 15a55112665aa24f9329629fe3ce5ca458b1c9da thank you!

This issue is verified on v2.5 and v2.6 latest build. User can pin website to Home page properly. [Build Info] 2.6 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08 gecko: https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26 2.5 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3