Closed Bug 1228352 Opened 9 years ago Closed 9 years ago

[Messages] Reduce the flickering happening in activities, and streamline animations

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file)

STR1: 1. Launch Gallery. 2. Display an image. 3. Share it with Messages. => Observe there is a white screen before the right panel is displayed. STR2: 1. Launch Contacts. 2. Display an contact. 3. Tap the 'send SMS' button. => Observe there is a white screen before the right panel is displayed.
Comment on attachment 8692551 [details] [gaia] julienw:less-flickering > mozilla-b2g:master Hey Oleg, what do you think ?
Attachment #8692551 - Flags: feedback?(azasypkin)
Assignee: nobody → felash
Comment on attachment 8692551 [details] [gaia] julienw:less-flickering > mozilla-b2g:master Having green background for app-in-activity-mode looks better than current state, and I like the cleanup because of using shared animations.css. However there is something wrong when we send group message - user is stuck in broken report view - commented at GitHub. Thanks!
Attachment #8692551 - Flags: feedback?(azasypkin) → feedback+
Comment on attachment 8692551 [details] [gaia] julienw:less-flickering > mozilla-b2g:master Hey Oleg, I think it's now ready for a review !
Attachment #8692551 - Flags: review?(azasypkin)
Comment on attachment 8692551 [details] [gaia] julienw:less-flickering > mozilla-b2g:master Looks good! I haven't noticed anything weird while testing your PR on device. I've left only very optional nit and one question-suggestion at GitHub. Thanks!
Attachment #8692551 - Flags: review?(azasypkin) → review+
Status: NEW → ASSIGNED
fixed latest nits and checked it was fine on a device + waited for a green build ! landed: master: https://github.com/mozilla-b2g/gaia/commit/37bcf558d16088130edafc41561d5c7f8910686a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: