Closed Bug 1230643 Opened 9 years ago Closed 9 years ago

Test titles are overly verbose when testname == suite

Categories

(Tree Management :: Perfherder, defect)

Product:
Tree Management
Component:
Perfherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wlach, Assigned: parkouss)

Details

(Whiteboard: perfherder-starter-bug)

User Story

Thank you for helping out with Treeherder!

You can find us on IRC at irc://irc.mozilla.org/treeherder

Here's some links to help get you started.

Project page:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder
https://wiki.mozilla.org/Auto-tools/Projects/Perfherder

Interacting with us, repo locations and links to set up a development version of the software:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs

A-Team general reference, coding style guides:
https://ateam-bootcamp.readthedocs.org

Attachments

(1 file)

avoid printing the test name twice
(deleted), text/x-github-pull-request
wlach
: review+
Details
For example, `sessionrestore_no_auto_restore`. It's way too long once, let alone twice. :) https://treeherder.mozilla.org/perf.html#/graphs?series=[mozilla-inbound,efaeb8a25bc6de40d38a0be504fb9125e1d9642f,1] I think we can just modify this function to get better behaviour: https://github.com/mozilla/treeherder/blob/master/ui/js/perf.js#L16
Whiteboard: perfherder-hackfest-mozlando
Whiteboard: perfherder-hackfest-mozlando → perfherder-starter-bug
User Story: (updated)
Assignee: nobody → j.parkouss
Attached file avoid printing the test name twice (deleted) —
So, that should do the job! This is looking good with the example provided at least. I'm not familiar yet with sending patches for perfherder, so if something is missing, tell me. :)
Attachment #8696854 - Flags: review?(wlachance)
Status: NEW → ASSIGNED
Comment on attachment 8696854 [details] avoid printing the test name twice This is good, however I don't *think* it will work for cases with abbreviated output, e.g. see tresize here: https://treeherder.mozilla.org/perf.html#/alerts?id=1635 (if I'm wrong, let me know)
Attachment #8696854 - Flags: review?(wlachance) → review-
Comment on attachment 8696854 [details] avoid printing the test name twice Oh yeah, I did not understood that the abbreviated part also needed to be fixed. So this should be better now, tell me if something is still not good.
Attachment #8696854 - Flags: review- → review?(wlachance)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8696854 - Flags: review?(wlachance) → review+
Depends on: 1240696
No longer depends on: 1240696
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: