Closed
Bug 1233566
Opened 9 years ago
Closed 9 years ago
"the property $FOO already exists" NS_WARNING has an awkward linebreak (cruft from being a "printf" call originally)
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Noticed this go by in my debug-build-spew today:
> [5463] WARNING: the property first_time_experience_button_label already exists
> : file ../../../mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532
Note the awkward newline before the ":". That's there because the NS_WARNING string has an explicit \n character, but it does not need one. (NS_WARNING adds the filename, line number, and a newline character after the provided string).
This dates back to bug 153754 when this warning was migrated from printf to NS_WARNING (and the "\n" from the printf expression was accidentally left in).
Filing this bug on dropping the \n so that the NS_WARNING displays on a single line without the awkward break.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
(Side note: bug 1233189 is already filed on the issue that's causing this warning to be spammed -- on first_time_experience_button_label being duplicated in a .properties file)
Updated•9 years ago
|
Attachment #8699639 -
Flags: review?(nfroyd) → review+
Comment 4•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•