Closed
Bug 1234289
Opened 9 years ago
Closed 9 years ago
antivirus should sleep longer between retry exceptions
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox44 fixed, firefox45 fixed, firefox46 fixed, firefox-esr38 fixed)
People
(Reporter: jlund, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
e.g.
10:45:39 INFO - Downloading pub/firefox/candidates/38.5.1esr-candidates/build1/update/win32/hr/firefox-38.5.0esr-38.5.1esr.partial.mar to cache/update/win32/hr/firefox-38.5.0esr-38.5.1esr.partial.mar
10:45:39 FATAL - Uncaught exception: Traceback (most recent call last):
10:45:39 FATAL - File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1693, in run
10:45:39 FATAL - self.run_action(action)
10:45:39 FATAL - File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1635, in run_action
10:45:39 FATAL - self._possibly_run_method(method_name, error_if_missing=True)
10:45:39 FATAL - File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1576, in _possibly_run_method
10:45:39 FATAL - return getattr(self, method_name)()
10:45:39 FATAL - File "scripts/scripts/release/antivirus.py", line 177, in get_files
10:45:39 FATAL - pool.map(worker, find_release_files())
10:45:39 FATAL - File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 227, in map
10:45:39 FATAL - return self.map_async(func, iterable, chunksize).get()
10:45:39 FATAL - File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 528, in get
10:45:39 FATAL - raise self._value
10:45:39 FATAL - IncompleteRead: IncompleteRead(0 bytes read, 5709261 more expected)
10:45:39 FATAL - Running post_fatal callback...
|
Reporter | |
Comment 1•9 years ago
|
||
turns out IncompleteRead is a subclass of HTTPException so antivirus does retry: https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/release/antivirus.py#160
Summary: antivirus should catch and retry on IncompleteRead exceptions → antivirus should sleep longer between retry exceptions
|
|
Reporter | |
Comment 2•9 years ago
|
||
Attachment #8700911 -
Flags: review?(rail)
|
||
Updated•9 years ago
|
Attachment #8700911 -
Flags: review?(rail) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 5•9 years ago
|
||
needs uplift to beta
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 6•9 years ago
|
||
maybe we should just uplift to esr as this seems pretty harmless
|
|
Reporter | |
Comment 7•9 years ago
|
||
uplifted all the way to esr38
|
||
Comment 8•9 years ago
|
||
I think we can close this - I've followed up with a comment on bug 1248299.
Flags: needinfo?(jlund)
|
|
Reporter | |
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(jlund)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•