Closed
Bug 1236550
Opened 9 years ago
Closed 9 years ago
Pinning to user environment during initial puppetization
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Infrastructure & Operations
RelOps: Puppet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Callek
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
(deleted),
text/x-github-pull-request
|
rail
:
review+
rail
:
checked-in+
|
Details |
AFAIK there is no easy way to use user environments during first puppetization, esp for aws_create_instance.py.
It'd be great to be able to pass --environment blah to puppetize.sh
|
Assignee | |
Comment 1•9 years ago
|
||
Something like this. cloud-tools PR incoming
Attachment #8703636 -
Flags: review?(bugspam.Callek)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8703636 [details] [diff] [review]
puppetize_pinned-puppet.diff
Review of attachment 8703636 [details] [diff] [review]:
-----------------------------------------------------------------
::: modules/puppet/files/puppetize.sh
@@ +175,5 @@
> # check for 'err:' in the output; this catches errors even
> # when the puppet exit status is incorrect.
> tmp=`mktemp /tmp/puppet-outputXXXXXX`
> [ -f "$tmp" ] || hang "mktemp failed"
> + /usr/bin/puppet agent $PUPPET_OPTIONS $PUPPET_EXTRA_OPTIONS> $tmp 2>1
nit space after "_EXTRA_OPTIONS"
Attachment #8703636 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8703636 [details] [diff] [review]
puppetize_pinned-puppet.diff
remote: https://hg.mozilla.org/build/puppet/rev/8bf88fc070ce
remote: https://hg.mozilla.org/build/puppet/rev/af48e0c8d654
Attachment #8703636 -
Flags: checked-in+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8704237 -
Flags: review?(bugspam.Callek)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8704237 [details]
cloud tools
r+ed in the PR.
Attachment #8704237 -
Flags: review?(bugspam.Callek)
Attachment #8704237 -
Flags: review+
Attachment #8704237 -
Flags: checked-in+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•