Closed Bug 1237066 Opened 9 years ago Closed 9 years ago

FeedWriter.js needs to use createCodebasePrincipal with global context user id

Categories

(Firefox :: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: huseby, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Whiteboard: [OA])

Attachments

(1 file, 1 obsolete file)

in browser/components/feeds/FeedWriter.js there is a call to getSimpleCodebasePrincipal that needs to be converted to createCodebasePrincipal with a global context user id. it is in the init function that sets up the principal for the feed. since we're not isolating on user context id, we need the global context to be used here. > 1085 this._feedPrincipal = secman.getSimpleCodebasePrincipal(this._feedURI);
Attached patch bug_1237066.patch (obsolete) (deleted) — Splinter Review
Assignee: huseby → amarchesini
Attachment #8704571 - Flags: review?(huseby)
Depends on: 1237078
Attachment #8704571 - Flags: review?(huseby) → review+
Depends on: 1229222
No longer depends on: 1237078
Attached patch Bug_1237066.patch (deleted) — Splinter Review
Attachment #8704571 - Attachment is obsolete: true
getSimpleCodebasePrincipal creates an origin attributes with the default user context ID so we don't need to fix this.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [OA]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: