Closed
Bug 1237078
Opened 9 years ago
Closed 9 years ago
live mark service needs to use createCodebasePrincipal and global user context id origin attribute
Categories
(Firefox :: Security, defect)
Firefox
Security
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: huseby, Assigned: huseby)
References
(Blocks 1 open bug)
Details
(Whiteboard: [OA])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
In the file toolkit/components/places/nsLivemarkService.js there are "feed principals" created to check if we can load the URI.
> 485 let feedPrincipal = secMan.getSimpleCodebasePrincipal(this.feedURI);
the getSimpleCodebasePrincipal call needs to be converted to createCodebasePrincipal calls with origin attributes that have the global user context id set.
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8717681 [details] [diff] [review]
Bug_1237078.patch
+ let attrs = ChromeUtils.createOriginAttributesFromOrigin(this.feedURI.spec);
Can you add a comment here that feeds will get the default user context id with this call to createOriginAttributesFromOrigin? That way if someone is looking into this later, they will see that we intentionally want to use the default context.
Assignee | ||
Comment 3•9 years ago
|
||
getSimpleCodebasePrincipal does the correct thing so we don't need to fix this.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8717681 [details] [diff] [review]
Bug_1237078.patch
this one is good to go.
Attachment #8717681 -
Flags: review?(jonas)
Comment on attachment 8717681 [details] [diff] [review]
Bug_1237078.patch
Review of attachment 8717681 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/places/nsLivemarkService.js
@@ +527,5 @@
> // automatically keep track of redirects, so we can always
> // cancel the channel.
> let loadgroup = Cc["@mozilla.org/network/load-group;1"].
> createInstance(Ci.nsILoadGroup);
> + let attrs = ChromeUtils.createOriginAttributesFromOrigin(this.feedURI.spec);
Again, won't this always be the default originAttributes?
Assignee | ||
Comment 6•9 years ago
|
||
This was resolved as won't fix because {} gives us the default origin attributes so we don't need to change the code. The default origin attributes is what we want.
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8717681 [details] [diff] [review]
Bug_1237078.patch
patch not needed.
Attachment #8717681 -
Flags: review?(jonas)
Assignee | ||
Updated•9 years ago
|
Whiteboard: [OA]
You need to log in
before you can comment on or make changes to this bug.
Description
•