+++ This bug was initially created as a follow-up of Bug #1215084 +++ Quote: It would be nice if we could fix https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/testbase.py#159 to be taskcluster aware. We'll need to get rid of buildbot specific stuff like this in mozharness anyway.

Changing the wording slightly, as we'll still need to support buildbot too for the time being.

We no longer need to support buildbot, so we can remove buildbot-specific stuff in mozharness.

Comment on attachment 8974140 [details] Bug 1237182: Removing unused buildbot support https://reviewboard.mozilla.org/r/242428/#review248634 Nothing bad stood out to be here. ::: testing/mozharness/mozharness/mozilla/testing/talos.py:207 (Diff revision 1) > - # no opts, check for '--geckoProfile' in try message text directly > - if self.try_message_has_flag('geckoProfile'): > - self.gecko_profile = True > - > # finally, if gecko_profile is set, we add that to the talos options > if self.gecko_profile: I *think* this branch is NOTREACHED now, but I am not certain.

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67d2aa892562 Removing unused buildbot support r=Callek

Backed out changeset 67d2aa892562 (bug 1237182) for breaking Decision task. CLOSED TREE Log: https://treeherder.mozilla.org/logviewer.html#?job_id=177910441&repo=autoland&lineNumber=1705 File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/schema.py", line 31, in validate_schema [task 2018-05-10T17:30:26.402Z] raise Exception('\n'.join(msg) + '\n' + pprint.pformat(obj)) [task 2018-05-10T17:30:26.402Z] Exception: In test 'raptor-firefox-tp6': [task 2018-05-10T17:30:26.402Z] extra keys not allowed @ data['mozharness']['no-read-buildbot-config'] [task 2018-05-10T17:30:26.402Z] {u'allow-software-gl-layers': False, [task 2018-05-10T17:30:26.402Z] u'build-attributes': {u'always_target': False, [task 2018-05-10T17:30:26.403Z] u'build_platform': u'macosx64', [task 2018-05-10T17:30:26.403Z] u'build_type': u'opt', [task 2018-05-10T17:30:26.403Z] u'kind': u'build', [task 2018-05-10T17:30:26.403Z] u'run_on_projects': [u'all'], [task 2018-05-10T17:30:26.403Z] u'shipping_phase': None, [task 2018-05-10T17:30:26.403Z] u'shipping_product': None}, [task 2018-05-10T17:30:26.403Z] u'build-label': u'build-macosx64/opt', [task 2018-05-10T17:30:26.403Z] u'build-platform': 'macosx64/opt', [task 2018-05-10T17:30:26.403Z] u'checkout': False, [task 2018-05-10T17:30:26.403Z] u'chunks': 1, [task 2018-05-10T17:30:26.403Z] 'description': 'Raptor Firefox tp6', [task 2018-05-10T17:30:26.403Z] u'docker-image': {u'in-tree': u'desktop1604-test'}, [task 2018-05-10T17:30:26.403Z] u'e10s': True, [task 2018-05-10T17:30:26.403Z] u'instance-size': u'default', [task 2018-05-10T17:30:26.403Z] u'job-from': 'raptor.yml', [task 2018-05-10T17:30:26.403Z] u'loopback-audio': False, [task 2018-05-10T17:30:26.403Z] u'loopback-video': False, [task 2018-05-10T17:30:26.403Z] 'max-run-time': 1200, [task 2018-05-10T17:30:26.403Z] 'mozharness': {u'chunked': False, [task 2018-05-10T17:30:26.403Z] u'chunking-args': u'this-chunk', [task 2018-05-10T17:30:26.404Z] 'config': {'by-test-platform': {'default': ['raptor/linux_config.py'], [task 2018-05-10T17:30:26.404Z] 'linux64-ccov/opt': ['raptor/linux64_config_taskcluster.py'], [task 2018-05-10T17:30:26.404Z] 'macosx.*': ['raptor/mac_config.py'], [task 2018-05-10T17:30:26.404Z] 'windows.*': ['raptor/windows_config.py'], [task 2018-05-10T17:30:26.404Z] 'windows10-64-ccov/debug': ['raptor/windows_vm_config.py']}}, [task 2018-05-10T17:30:26.404Z] 'extra-options': ['--test=raptor-firefox-tp6'], [task 2018-05-10T17:30:26.404Z] 'no-read-buildbot-config': True, [task 2018-05-10T17:30:26.404Z] u'requires-signed-builds': False, [task 2018-05-10T17:30:26.404Z] 'script': 'raptor_script.py', [task 2018-05-10T17:30:26.404Z] u'set-moz-node-path': True, [task 2018-05-10T17:30:26.404Z] u'tooltool-downloads': False}, [task 2018-05-10T17:30:26.404Z] u'os-groups': [], [task 2018-05-10T17:30:26.405Z] u'reboot': False, [task 2018-05-10T17:30:26.405Z] 'run-on-projects': {'by-test-platform': {'.*-qr/.*': ['try'], [task 2018-05-10T17:30:26.405Z] 'default': ['try']}}, [task 2018-05-10T17:30:26.405Z] 'suite': 'raptor', [task 2018-05-10T17:30:26.405Z] u'test-name': 'raptor-firefox-tp6', [task 2018-05-10T17:30:26.405Z] u'test-platform': 'macosx64/opt', [task 2018-05-10T17:30:26.405Z] 'tier': {'by-test-platform': {'default': 3, [task 2018-05-10T17:30:26.405Z] 'linux64-ccov/.*': 3, [task 2018-05-10T17:30:26.405Z] 'windows10-64-ccov/.*': 3}}, [task 2018-05-10T17:30:26.405Z] 'treeherder-symbol': 'Rap(tp6)', [task 2018-05-10T17:30:26.405Z] 'try-name': 'raptor-firefox-tp6', [task 2018-05-10T17:30:26.405Z] 'virtualization': {'by-test-platform': {'default': 'hardware', [task 2018-05-10T17:30:26.405Z] 'windows10-64-ccov/.*': 'virtual'}}, [task 2018-05-10T17:30:26.405Z] u'webrender': False} [taskcluster 2018-05-10 17:30:26.787Z] === Task Finished === Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=67d2aa892562cb25bff4a7707b016f20560873a3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=177910441 Backout: https://hg.mozilla.org/integration/autoland/rev/9b3ba34a7a1a77c3d9487c557d13e8691879f877

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba91fec47e90 Removing unused buildbot support r=Callek

Pushed by acelists@atlas.sk: https://hg.mozilla.org/comm-central/rev/d288b2be548c Port bug 1237182 - remove buildbot specific stuff. rs=bustage-fix

Backed out for breaking the Windows 2012 Nightlies. "IOError: Can't find buildprops.json in ['.', 'Z:\\task_1526126483\\build\\src\\testing\\mozharness\\configs']!" Backout link: https://hg.mozilla.org/mozilla-central/rev/df5dae2daa1b920a3c94e2647a7bd8c2b4a3d48e Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=178176514&repo=mozilla-central&lineNumber=576

C-C backout: https://hg.mozilla.org/comm-central/rev/2095ab9585866cef1902d32ddcc9137faff6de51 Backed out changeset d288b2be548c: Port of bug 1237182 which was backed out from M-C. a=jorgk

Comment on attachment 8974140 [details] Bug 1237182: Removing unused buildbot support https://reviewboard.mozilla.org/r/242428/#review250182 catlee asked me to look at the interdiff (4-5) and it looks good to me.

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f6fc4ca009e Removing unused buildbot support r=Callek

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/2b3ad9ae9b0d Port bug 1237182 - Remove unused buildbot support. rs=bustage-fix

MozReview-Commit-ID: GN7lGzWwcvx

MozReview-Commit-ID: GN7lGzWwcvx

Do we also need to remove the references to read_buildbot_config ? <https://searchfox.org/mozilla-central/search?q=read_buildbot_config>

(In reply to Bob Clary [:bc:] from comment #23) > Do we also need to remove the references to read_buildbot_config ? > <https://searchfox.org/mozilla-central/search?q=read_buildbot_config> Yes, I've got other patches in the works that do that.

Comment on attachment 8976663 [details] Bug 1237182: Remove unused mapper mixin Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1305

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e42d9f0a9028 Remove unused mapper mixin r=Callek

Comment on attachment 8977056 [details] Bug 1237182: Get rid of taskcluster helpers Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1313

Comment on attachment 8977057 [details] Bug 1237182: remove mock(chroot) support Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1314

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0bc0174b2d41 Get rid of taskcluster helpers r=Callek

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c984d9497e88 remove mock(chroot) support r=Callek

Comment on attachment 8977058 [details] Bug 1237182: removing some blobber references Mihai Tabara [:mtabara]⌚️GMT has approved the revision. https://phabricator.services.mozilla.com/D1315

https://hg.mozilla.org/mozilla-central/rev/0bc0174b2d41 https://hg.mozilla.org/mozilla-central/rev/c984d9497e88

Pushed by catlee@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/3fc29973e494 Fix android l10n nightlies a=bustage

Comment on attachment 8977076 [details] Bug 1237182: remove mozharness purge mixin r=Callek Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1318

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a1c5ca0c2a93 Remove mozharness blobber mixin r=mtabara https://hg.mozilla.org/integration/mozilla-inbound/rev/a04929db78d3 Remove mozharness purge mixin r=Callek

https://hg.mozilla.org/mozilla-central/rev/a1c5ca0c2a93 https://hg.mozilla.org/mozilla-central/rev/a04929db78d3

Comment on attachment 8980077 [details] Bug 1237182: Remove more buildbot references from mozharness r=Callek Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1372

Comment on attachment 8980076 [details] Bug 1237182: Remove BuildbotMixin in favour of AutomationMixin r=Callek Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1371

Comment on attachment 8980642 [details] [diff] [review] raptor.diff Review of attachment 8980642 [details] [diff] [review]: ----------------------------------------------------------------- LGTM and I see your raptor try push is green, thank you!

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5563ed803d7f Remove more buildbot references from mozharness r=Callek https://hg.mozilla.org/integration/mozilla-inbound/rev/c53ad5b24efd Remove BuildbotMixin in favour of AutomationMixin r=Callek https://hg.mozilla.org/integration/mozilla-inbound/rev/d52176ab1ec9 remove buildbot_config from raptor mixin r=rwood

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfce79fc419 Fix python unitests r=bustage on a CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/5563ed803d7f https://hg.mozilla.org/mozilla-central/rev/c53ad5b24efd https://hg.mozilla.org/mozilla-central/rev/d52176ab1ec9 https://hg.mozilla.org/mozilla-central/rev/9bfce79fc419

Comment on attachment 8981458 [details] Bug 1237182: Remove set_property(..., write_to_file) support r=tomprince,Callek Tom Prince [:tomprince] has approved the revision. https://phabricator.services.mozilla.com/D1447

Comment on attachment 8981455 [details] Bug 1237182: get rid of oauth.txt Mihai Tabara [:mtabara]⌚️GMT has approved the revision. https://phabricator.services.mozilla.com/D1444

Comment on attachment 8981456 [details] Bug 1237182: Clean up codecoverage property helpers Tom Prince [:tomprince] has approved the revision. https://phabricator.services.mozilla.com/D1445

Comment on attachment 8982202 [details] Bug 1237182: Remove default_blob_upload_servers r=mtabara Mihai Tabara [:mtabara]⌚️GMT has approved the revision. https://phabricator.services.mozilla.com/D1474

Comment on attachment 8982372 [details] Bug 1237182: [mozharness] Remove some obsolete solaris related configuration; r?catlee Chris AtLee [:catlee] has approved the revision. https://phabricator.services.mozilla.com/D1482

Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/b36a59489f4d [mozharness] Remove some obsolete solaris related configuration; r=catlee

Comment on attachment 8981454 [details] Bug 1237182: Get rid of buildprops.json Tom Prince [:tomprince] has approved the revision. https://phabricator.services.mozilla.com/D1443

Comment on attachment 8981454 [details] Bug 1237182: Get rid of buildprops.json Simon Fraser [:sfraser] ⌚️GMT has approved the revision. https://phabricator.services.mozilla.com/D1443

Comment on attachment 8981458 [details] Bug 1237182: Remove set_property(..., write_to_file) support r=tomprince,Callek Justin Wood (:Callek) has approved the revision. https://phabricator.services.mozilla.com/D1447

Comment on attachment 8981457 [details] Bug 1237182: Remove unused try message handling r=tomprince Tom Prince [:tomprince] has approved the revision. https://phabricator.services.mozilla.com/D1446

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dab1fa529286 Get rid of buildprops.json r=tomprince,sfraser https://hg.mozilla.org/integration/mozilla-inbound/rev/de5086b44a78 get rid of oauth.txt r=mtabara https://hg.mozilla.org/integration/mozilla-inbound/rev/76667272ca81 Clean up codecoverage property helpers r=tomprince https://hg.mozilla.org/integration/mozilla-inbound/rev/9061381462ac Remove unused try message handling r=tomprince https://hg.mozilla.org/integration/mozilla-inbound/rev/feda34d6ae78 Remove set_property(..., write_to_file) support r=tomprince,Callek https://hg.mozilla.org/integration/mozilla-inbound/rev/3b9d55ec3055 Remove default_blob_upload_servers r=mtabara

https://hg.mozilla.org/mozilla-central/rev/dab1fa529286 https://hg.mozilla.org/mozilla-central/rev/de5086b44a78 https://hg.mozilla.org/mozilla-central/rev/76667272ca81 https://hg.mozilla.org/mozilla-central/rev/9061381462ac https://hg.mozilla.org/mozilla-central/rev/feda34d6ae78 https://hg.mozilla.org/mozilla-central/rev/3b9d55ec3055

The bulk of the buildbot specific code has been removed from mozharness now. I'm calling this done \o/