In support of bug 1224408, update the puppet script for building yasm for the mac builders.

Comment on attachment 8706686 [details] [diff] [review] Update yasm-dmg.sh for yasm 1.3.0 Review of attachment 8706686 [details] [diff] [review]: ----------------------------------------------------------------- ::: modules/packages/manifests/yasm-dmg.sh @@ +20,5 @@ > > +VERSION=1.3.0 > +SHA2=3dce6601b495f5b3d45b59f7d2492a340ee7e84b5beca17e48f862502bd5603f > +curl -LO https://www.tortall.net/projects/yasm/releases/yasm-$VERSION.tar.gz > +CHECKSUM=$(shasum -a 256 yasm-$VERSION.tar.gz | cut -d ' ' -f 1) :heart:

https://hg.mozilla.org/build/puppet/rev/b09df965e6eca93ab4d554a211db504df3a48d3b Bug 1238798 - Update puppet yasm-dmg.sh for yasm 1.3.0. r=dustin

Incidentally, mozreview is set up for this repo too if you'd like to use that. Now, to figure out how to upgrade this. It's easy enough to change the version number in the puppet manifests, and as machines reboot they will pick up the new version. But that doesn't give us a per-tree approach, nor does it allow us to make a crisp transition. How do you think we should proceed?

It's at http://puppetagain.pub.build.mozilla.org/data/repos/DMGs/10.7/yasm-1.3.0.dmg if you want to verify.

Thanks. yasm-1.3.0.dmg looks fine to me. From what you say, to proceed, I suggest we: 1. Checkout one of the builders, install the pkg manually, and verify it works in the actual build environment. 2. Bump the puppet manifest to point to the new package, reboot and verify at least one machine. 3. Schedule all the machines to reboot so we get timely rollout. I'll see about checking out a machine unless you have perms to do that directly.

Looks like step 1 is well underway. I'll send a review req for the version bump your way. Note that we don't have a way to schedule reboots. Instead, machines reboot after finishing each job, and when they've been idle for a while. In general, that's at least once a day. But we'll have mixed results for a while.

Review commit: https://reviewboard.mozilla.org/r/30729/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30729/

Ok, mixed results over a day is fine. I just didn't want things to take weeks.

Comment on attachment 8707485 [details] MozReview Request: Bug 1238798: bump yasm to 1.3.0 on Darwin; r?rillian https://reviewboard.mozilla.org/r/30729/#review27545 I wondered if that was all that was required. Thanks for doing this bit!

The yasm 1.3.0 pkg installed manually on the loaner machine, and I was able to run yasm --version. Just waiting for a firefox build to complete for final confirmation.

Build with the new yasm confirmed working on a loaner machine. If you merge the puppet update, I'll check deployment.

https://hg.mozilla.org/build/puppet/rev/664f51297aa85887849150e92abc0a6fbcd2f6a3 Bug 1238798: bump yasm to 1.3.0 on Darwin; r=rillian

OK, it's landed

Saw the first yasm 1.3.0 on and inbound build. Looks like the rollout is happening. Thanks for your help, Dustin!