Closed
Bug 1239003
Opened 9 years ago
Closed 9 years ago
remove no-longer-used mozharness directories that have been moved intree
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hwine, Assigned: hwine)
References
Details
Attachments
(2 files)
(deleted),
text/plain
|
jlund
:
review+
hwine
:
checked-in+
|
Details |
(deleted),
patch
|
jlund
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1225364 +++
Rail Aliiev said in bug 1224903 comment #6:
> testing/mozharness is the main repo and
> https://hg.mozilla.org/build/mozharness/ is a fork for a couple of projects
> that are not tracking changes in the main repo. Bumper and vcssync are 2 of
> those afaik.
>
> Hal, maybe we should remove the outdated bumper and vcssync configs in
> testing/mozharness to avoid this confusion?
This is the converse of bug 1225364 -- stripping everything but bumper & vcssync from the mozharness repo.
Assignee | ||
Comment 1•9 years ago
|
||
:jlund -- any concerns about doing this? (You were more involved in the in-tree discussions than I.)
My rough plan is:
- verify neither of b2g_bumper or vcssync import anything "outside" of their world
- delete everything else on default
- commit to default & let tests run
- push to production and:
a) monitor b2g_bumper and vcs-sync myself
b) have sheriffs monitor for any intree impact
Assignee: nobody → hwine
Status: NEW → ASSIGNED
Flags: needinfo?(jlund)
QA Contact: jlund → hwine
Comment 2•9 years ago
|
||
(In reply to Hal Wine [:hwine] (use NI) from comment #1)
> :jlund -- any concerns about doing this? (You were more involved in the
> in-tree discussions than I.)
>
> My rough plan is:
> - verify neither of b2g_bumper or vcssync import anything "outside" of
> their world
> - delete everything else on default
> - commit to default & let tests run
> - push to production and:
> a) monitor b2g_bumper and vcs-sync myself
> b) have sheriffs monitor for any intree impact
sounds reasonable to me. thanks for grabbing this!
higher level, iiuc -
* hg.m.o/build/mozharness - vcssync and b2g_bumper:
** remove all in scripts/* _except_:
*** http://hg.mozilla.org/build/mozharness/file/a82dd0a120ed/scripts/b2g_bumper.py
*** http://hg.mozilla.org/build/mozharness/file/a82dd0a120ed/scripts/vcs-sync
** remove all in configs/* _except_:
*** http://hg.mozilla.org/build/mozharness/file/a82dd0a120ed/configs/b2g_bumper
*** http://hg.mozilla.org/build/mozharness/file/a82dd0a120ed/configs/b2g_bumper
** leave mozharness/base/* as is (keeping this code in both will largely be required and tolerated to diverge overtime
** that leaves mozharness/mozilla/* as the murky grey area
** I am not familiar with vcssync or bumper but it shouldn't be too bad going through those scripts and seeing which imports use subclasses from: http://hg.mozilla.org/build/mozharness/file/a82dd0a120ed/mozharness/mozilla
then, for {gecko}/testing/mozharness/: do the opposite of above ^
does this help?
Flags: needinfo?(jlund)
Assignee | ||
Comment 3•9 years ago
|
||
With the attached removals:
a) All tox tests still pass:
-----------------------------------------------------------------------
178 tests run in 55.6 seconds.
2 skipped (176 tests passed)
______________________ summary ________________________________________
py27-hg2.6: commands succeeded
congratulations :)
b) import of every b2g_bumper & vcs_sync script & config file succeeds without error
The removal is for 226 files, 174 remain.
Attachment #8707225 -
Flags: review?(jlund)
Comment 5•9 years ago
|
||
Comment on attachment 8707225 [details]
Proposed deletions
there are probably mozharness/mozilla/* files that can go but this is the minimum and will be a huge help.
Attachment #8707225 -
Flags: review?(jlund) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8707226 [details] [diff] [review]
README.patch
Review of attachment 8707226 [details] [diff] [review]:
-----------------------------------------------------------------
::: README.md
@@ +1,2 @@
> # Mozharness
> This repository is a downstream read-only copy of:
maybe this shouldn't say 'read-only' since we can write to build/mozharness for bumper/vcssync sake
Attachment #8707226 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/build/mozharness/rev/09fbd2d2aee9ceeba3e1fc0dccb176159fb6dc76
bug 1239003 - repo only for non-gecko apps now; r=jlund
https://hg.mozilla.org/build/mozharness/rev/c200b40698620b5ac0fb15d4edb803fd55a96b41
bug 1239003 - repo only for non-gecko apps now; r=jlund
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8707225 [details]
Proposed deletions
on default
Attachment #8707225 -
Flags: checked-in+
Assignee | ||
Comment 9•9 years ago
|
||
travis tests passed, now on production
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•