Linear layout inside scroll view should use wrap_content instead of match_parent for height [1], [2], [3]. [1] https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/firstrun_import_fragment.xml#14 [2] https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/firstrun_sync_fragment.xml#14 [3] https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/firstrun_welcome_fragment.xml#14

The first file in the above mentioned list is not found. Made the change in the other two files. Please have a look.

Comment on attachment 8725385 [details] [diff] [review] Bug1241941_v1.diff Review of attachment 8725385 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! However, the code for the first file was moved here: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/firstrun_basepanel_fragment.xml#14 Can you update that one too? btw, you can find the most up-to-date lint issues by running `mach gradle app:lint` and opening the result file.

Hello Comella I was not able to run 'mach gradle app:lint' as it thrower out some error(which I will get it fixed from IRC). Anyway, I have done the necessary changes to the first file also. Please check. Cheers.

Comment on attachment 8725662 [details] [diff] [review] Bug1241941_v2.diff Review of attachment 8725662 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Micheal, Can you please do a super review?

Comment on attachment 8725662 [details] [diff] [review] Bug1241941_v2.diff Review of attachment 8725662 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! Let me know if you need help trying to get your linting working! Just so you know, I filed a follow-up (bug 1253126) to make sure future failures appear as lint errors, rather than just a warning.

Don't forget to add checkin-needed!