Closed
Bug 1241955
Opened 9 years ago
Closed 9 years ago
Enable tests on date
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: jlund)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Callek
:
review+
jlund
:
checked-in+
|
Details | Diff | Splinter Review |
Ryan asked today what the default update channel is in release promotion and mentioned that some tests may fail if they get an update prompt.
We should enable tests to see what else is broken :)
Reporter | ||
Comment 1•9 years ago
|
||
Assignee: nobody → rail
Attachment #8717287 -
Flags: review?(bugspam.Callek)
Comment 2•9 years ago
|
||
Comment on attachment 8717287 [details] [diff] [review]
enable_tests.diff
Review of attachment 8717287 [details] [diff] [review]:
-----------------------------------------------------------------
I'd be interested in an explicit builderlist diff with this. As well as a verification we're not tripping over the max builders per master PB_* setting as a sanity check.
That said, even if we are we should find some way to accommodate this for our needs. -- r+ unless there is wider changes needed.
Attachment #8717287 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 3•9 years ago
|
||
judging by my verify_patch script I don't think this patch will be enough. We may need to tweak something like 'platforms' or the 'slave_platforms' within 'platforms': https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/project_branches.py#143
Assignee | ||
Comment 4•9 years ago
|
||
builder_diff of this patch: http://people.mozilla.org/~jlund/date_unittests-builder_diff.diff
notice this jumps us by 5% to 98% cap
the previous patch yielded a no-op diff without removing slave_platforms from the platforms list.
Attachment #8720143 -
Flags: review?(bugspam.Callek)
Comment 5•9 years ago
|
||
Comment on attachment 8720143 [details] [diff] [review]
160216_date_unittests.patch
Review of attachment 8720143 [details] [diff] [review]:
-----------------------------------------------------------------
I'm saddened at buildercount concerns here..... fwiw.
Attachment #8720143 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8720143 [details] [diff] [review]
160216_date_unittests.patch
remote: https://hg.mozilla.org/build/buildbot-configs/rev/cc561d788755
Attachment #8720143 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Attachment #8717287 -
Attachment is obsolete: true
Comment 7•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
Assignee: rail → jlund
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•