Closed Bug 124205 Opened 23 years ago Closed 20 years ago

Trunk N621 M100 crashes installing themes [@ nsHTMLReflowState::DetermineFrameType]

Categories

(SeaMonkey :: Themes, defect, P1)

1.0 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: greer, Assigned: shliang)

References

()

Details

(Keywords: crash, topcrash-, Whiteboard: (jp))

Crash Data

Both M098 and the Trunk are showing this signature in the topcrash lists. The comments clearly point to problems created by switching themes. Looking at the Talkback data there are a few isolated incidents as far back as N6.10. It is showing up in significant numbers in the recent Trunk builds and M098. Stack Trace: nsHTMLReflowState::DetermineFrameType [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp line 363] nsHTMLReflowState::Init [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp line 247] nsHTMLReflowState::nsHTMLReflowState [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp line 224] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp line 979] nsInlineFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 713] nsInlineFrame::ReflowFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 522] nsInlineFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 438] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp line 1087] nsInlineFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 713] nsInlineFrame::ReflowFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 522] nsInlineFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 438] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp line 1087] nsBlockFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3735] nsBlockFrame::DoReflowInlineFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3616] nsBlockFrame::DoReflowInlineFramesAuto [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3541] nsBlockFrame::ReflowInlineFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3486] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2640] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2279] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 846] nsBlockReflowContext::DoReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 581] nsBlockReflowContext::ReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 359] nsBlockFrame::ReflowBlockFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3230] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2506] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2279] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 846] nsBlockReflowContext::DoReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 581] nsBlockReflowContext::ReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 359] nsBlockFrame::ReflowBlockFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3230] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2506] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2279] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 846] nsBlockReflowContext::DoReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 581] nsBlockReflowContext::ReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 359] nsBlockFrame::ReflowBlockFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3230] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2506] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2279] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 846] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 771] CanvasFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLFrame.cpp line 564] nsBoxToBlockAdaptor::Reflow [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxToBlockAdaptor.cpp line 843] nsBoxToBlockAdaptor::DoLayout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxToBlockAdaptor.cpp line 606] nsBox::Layout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp line 1052] nsScrollBoxFrame::DoLayout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsScrollBoxFrame.cpp line 395] nsBox::Layout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp line 1052] nsContainerBox::LayoutChildAt [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsContainerBox.cpp line 654] nsGfxScrollFrameInner::LayoutBox [d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp line 1072] nsGfxScrollFrameInner::Layout [d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp line 1231] nsGfxScrollFrame::DoLayout [d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp line 1080] nsBox::Layout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp line 1052] nsBoxFrame::Reflow [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxFrame.cpp line 991] nsGfxScrollFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp line 789] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 771] ViewportFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsViewportFrame.cpp line 574] PresShell::ResizeReflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp line 2811] PresShell::ResizeReflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp line 6064] nsViewManager::SetWindowDimensions [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp line 585] nsViewManager::DispatchEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp line 1816] HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 83] nsWindow::DispatchEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 854] nsWindow::DispatchWindowEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 871] nsWindow::OnResize [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4386] nsWindow::ProcessMessage [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 3654] nsWindow::WindowProc [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 1116] USER32.dll + 0x3a5f (0x77d43a5f) Source File : http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/html/base/src/nsHTMLR eflowState.cpp line : 363 (2605292) URL: www.namezero.com (2602877) URL: www.macnn.com (2602877) Comments: switching to the modern theme. (2597316) URL: https://www.mbank.com.pl/ (2597316) Comments: While trying to change skin... (2589007) Comments: theme switch (2586854) Comments: downloading star trek theme caused browser to die (2583038) Comments: installing new theme (2582931) Comments: installing new theme (2574451) Comments: Used Apply Theme (2573786) URL: http://helloweb.com/index.html (2573786) Comments: Switching from the classic to the modern theme. (2570786) Comments: changing the modern theme back to classic (2566407) Comments: changing from the classic theme to the modern theme. (2564982) Comments: Saving new navigator preferences (2563264) URL: www.iht.com (2560542) Comments: switching themes from classic to modern (2554713) Comments: Switching from Classic to Modern. (2549137) Comments: Tried to change to ToyFactory-theme. However this theme is still for Netscape 6.1 and I use Mozilla 0.9.8. Any news about theme-updates ? (2545907) Comments: Started mozilla with modern as default theme then tried to switch to classic theme from View > Apply Theme > Classic. (2545869) Comments: Changed to classic theme (2545449) URL: http://commcenter.net2phone.com/GLPPublish.asp?idpage=startdl (2537778) Comments: Trying to change the theme to "Modern" (2531919) Comments: I changed the theme from classic to modern (2529062) URL: my.yahoo.com (2529062) Comments: I had just installed Mozilla and gone to my home page (My Yahoo) when I tried to switch themes (to the Modern theme). That is where it crashed. (2526537) Comments: Changed the theme for the first time: from classic to modern (2525443) Comments: Trying to use a Netscape theme with mozilla (2522448) URL: soribada.kldp.org (2522448) Comments: lo-fi classic theme of xulplanet broken with 0.9.8.so applied classic one. and lo-fi again. it apeears well.but new window broken again. then classic applied again.the applying task was in while opening other tabs and windows.mozilla crashed. (2522392) Comments: switch theme from classic to modern (2520770) URL: www.icicidirect.com (2520770) Comments: I had 2 sites opened in tabbed view When i tried to switch between the skins from modern to classic mozilla crashed ------------ Trunk crash comments: (2576243) Comments: I think that the theme that is currently active does not really "work" with this version of Mozilla. I tried to switch from that theme to Modern and the app crashed. (2546229) Comments: Updating the skin to LittleMozilla (2517016) Comments: shift theme (2436377) URL: http://www.netscape.com/themes (2436377) Comments: Opened up a huge amount of windows for fun and tried to switch themes (2423058) Comments: changing from classic to modern (2265974) URL: wannabe.gathering.org/tg (2265974) Comments: switching skin from classic to modern
Keywords: crash, topcrash
Marking nsbeta1+
Keywords: nsbeta1+
Target Milestone: --- → mozilla1.0
although we have plenty of comments that mention switching themes to cause a crash, we still don't have a solid testcase. adding qawanted keyword to see if someone can find consistent steps to reproduce this crash.
Keywords: qawanted
Petersen showed me a way to reproduce it. Basically, I just hopped between a couple of sites (http://helloweb.com/index.html and my.yahoo.com) and switched themes until it crashed. I got the same stack as initially reported. What I see in the debugger is that the frame for an HR element has totally bugus style information. Fortunately, it is all null, so I can bullet-proof it and probably avoid the crash. Why it is bogus in the first place I do no know yet, but I'm investigating.
Status: NEW → ASSIGNED
Priority: -- → P1
Here are my steps that help me reproduce it too. Tested with Feb 2002-02-18-03 (Win Me) and Feb 2002-02-19-07 (Mac OS X). 1) Launch app with classic theme. 2) Go to this bug. 3) Click on http://helloweb.com/index.html. 4) When page is displayed, choose Modern from View - Apply Theme. 5) Press the Back arrow toolbar icon. 6) Press Forward arrow toolbar icon. 7) Switch to Classic theme from View- Apply Theme 8) Press the Back arrow toolbar icon. 9) Press Forward arrow toolbar icon. 10) Switch to Classic theme from View- Apply Theme.
Priority: P1 → --
Adding testcase keyword. Chris and Marc both say they can reproduce this one. Changing Platform/OS to 'all' since Chris says he can crash OS X (comment #4). Curious if this one could sneak aboard M099.
Keywords: qawantedtestcase
OS: Windows 2000 → All
Hardware: PC → All
OS/2 2002022008 Don't know whether this is the right place. Many apply theme crashes in bugzilla search. Found during attempt to confirm fix to bug 120838. Simple testcase starting Mozilla already in modern: 1-use prefs to switch to classic 2-exit prefs 3-use prefs to switch to modern 4-trap: 02-20-2002 19:04:34 SYS3175 PID 00c0 TID 0001 Slot 0081 H:\MOZILLA\BIN\MOZILLA.EXE c0000005 1db7480e P1=00000001 P2=00000001 P3=XXXXXXXX P4=XXXXXXXX EAX=00000001 EBX=00000000 ECX=1dc1c52c EDX=0013019c ESI=1dc1c52c EDI=0013019c DS=0053 DSACC=f0f3 DSLIM=ffffffff ES=0053 ESACC=f0f3 ESLIM=ffffffff FS=150b FSACC=00f3 FSLIM=00000030 GS=0000 GSACC=**** GSLIM=******** CS:EIP=005b:1db7480e CSACC=f0df CSLIM=ffffffff SS:ESP=0053:00130184 SSACC=f0f3 SSLIM=ffffffff EBP=00a64824 FLG=00012202 GKCONTNT.DLL 0001:001a480e
--> P1 since we can repro this one.
Priority: -- → P1
nsbeta1-. Since this we will require restart on theme switch. See bug 127784.
Keywords: nsbeta1+nsbeta1-
Target Milestone: mozilla1.0 → Future
Depends on: 127784
Making topcrash+. Even if this doesn't get fixed directly, we need to make sure to verify this is gone after dynamic theme switching is disabled.
Keywords: topcrashtopcrash+
Can anyone reproduce this in anyway with a recent Trunk build? Dependant bug 127784 has been verified fixed...dynamic theme switching was disabled on 3/24. However, I see a crash with a build from 3/25 with the same stack signature and trace. Not sure if it's a theme switching crash or not, since there aren't any user comments. Here's the incident: Incident ID 4481805 Stack Signature nsHTMLReflowState::DetermineFrameType f536d065 Trigger Time 2002-03-26 02:03:08 Email Address URL visited Build ID 2002032510 Product ID MozillaTrunk Platform Operating System Win32 Module Trigger Reason Access violation User Comments Stack Trace nsHTMLReflowState::DetermineFrameType [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp, line 371] nsHTMLReflowState::Init [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp, line 255] nsHTMLReflowState::nsHTMLReflowState [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp, line 230] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp, line 981] nsInlineFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp, line 723] nsInlineFrame::ReflowFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp, line 532] nsInlineFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp, line 448] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp, line 1089] nsBlockFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3695] nsBlockFrame::DoReflowInlineFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3576] nsBlockFrame::DoReflowInlineFramesAuto [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3501] nsBlockFrame::ReflowInlineFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3446] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 2612] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 2251] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 846] nsBlockReflowContext::DoReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp, line 581] nsBlockReflowContext::ReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp, line 359] nsBlockFrame::ReflowBlockFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3202] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 2478] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 2251] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 846] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 805] nsTableCellFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableCellFrame.cpp, line 946] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 805] nsTableRowFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp, line 1257] nsTableRowFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp, line 1149] nsTableRowFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp, line 1426] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 805] nsTableRowGroupFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp, line 1577] nsTableRowGroupFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp, line 1248] nsTableRowGroupFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp, line 1156] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 805] nsTableFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp, line 3005] nsTableFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp, line 2721] nsTableFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp, line 1964] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 805] . . . . There's more to the stack, but it's way too long...and probably not useful. If no one is able to reproduce this with a more recent MozillaTrunk build doing any kind of theme switching, we should just mark this one worksforme. Since there shouldn't be anymore theme switching crashes with this stack signature, any new crashes not involving themes should be logged as separate bugs.
Blocks: 134260
I took a look at the recent Trunk data and found crash incidents on the following (post 3/24) builds: Trunk (nsHTMLReflowState::DetermineFrameType): 6 2002040110 2002040106 2002032810 2002032711 2002032510 Two crashes with comments: (4574295) - [Windows NT 5.0 build 2195]: Downloading pinbal skin (v1.0.1) (4735840) - [Windows NT 4.0 build 1381]: I was installing the moderngray mozilla theme. I thought these were going away with dynamic theme switching.
Regarding comment 3 -- I suspect the problem here was the generated content frame, and the problem is that RemoveGeneratedContentFrameSiblings still isn't working quite right. There's another bug on that somewhere.
dbaron, I believe the bug you mention in comment #12 is bug 126072. FWIW - Latest Trunk incident. (4971438) - [2002040711 - 2002-04-08] Was installing a new skin (Grey Modern 1.0.1) Windows NT 5.0 build 2195
This is still a problem with Mozilla 1.0 RC3...adding M1RC3 and updating summary. Users seem to be crashing after installing 3rd party themes: =============================================================================================== Count Offset Real Signature [ 18 nsHTMLReflowState::DetermineFrameType c16db802 - nsHTMLReflowState::DetermineFrameType ] Crash date range: 2002-05-24 to 2002-05-28 Min/Max Seconds since last crash: 158 - 361925 Min/Max Runtime: 158 - 361925 Keyword List : download(5), install(6), load(6), theme(9), Count Platform List 11 Windows NT 5.0 build 2195 3 Windows NT 5.1 build 2600 2 Windows 98 4.10 build 67766446 1 Windows 98 4.90 build 73010104 1 Windows 98 4.10 build 67766222 Count Build Id List 18 2002052308 No of Unique Users 18 Stack trace(Frame) nsHTMLReflowState::DetermineFrameType [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp line 383] nsHTMLReflowState::Init [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp line 267] nsHTMLReflowState::nsHTMLReflowState [d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp line 242] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp line 981] nsInlineFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 732] nsInlineFrame::ReflowFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 532] nsInlineFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp line 448] nsLineLayout::ReflowFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp line 1089] nsBlockFrame::ReflowInlineFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3697] nsBlockFrame::DoReflowInlineFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3578] nsBlockFrame::DoReflowInlineFramesAuto [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3503] nsBlockFrame::ReflowInlineFrames [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3448] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2606] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2245] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 852] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableCellFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableCellFrame.cpp line 959] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableRowFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp line 1300] nsTableRowFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp line 1192] nsTableRowFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp line 1453] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableRowGroupFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp line 1623] nsTableRowGroupFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp line 1294] nsTableRowGroupFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp line 1203] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp line 3164] nsTableFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp line 2880] nsTableFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp line 2114] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableOuterFrame::OuterReflowChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1028] nsTableOuterFrame::IR_InnerTableReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1345] nsTableOuterFrame::IR_TargetIsInnerTableFrame [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1134] nsTableOuterFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1124] nsTableOuterFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1087] nsTableOuterFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1585] nsBlockReflowContext::DoReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 581] nsBlockReflowContext::ReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 359] nsBlockFrame::ReflowBlockFrame [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 3204] nsBlockFrame::ReflowLine [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2472] nsBlockFrame::ReflowDirtyLines [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 2245] nsBlockFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp line 852] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableCellFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableCellFrame.cpp line 959] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableRowFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp line 1300] nsTableRowFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp line 1192] nsTableRowFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp line 1453] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableRowGroupFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp line 1623] nsTableRowGroupFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp line 1294] nsTableRowGroupFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp line 1203] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp line 3164] nsTableFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp line 2880] nsTableFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp line 2114] nsContainerFrame::ReflowChild [d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp line 807] nsTableOuterFrame::OuterReflowChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1028] nsTableOuterFrame::IR_InnerTableReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1345] nsTableOuterFrame::IR_TargetIsInnerTableFrame [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1134] nsTableOuterFrame::IR_TargetIsChild [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1124] nsTableOuterFrame::IncrementalReflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1087] nsTableOuterFrame::Reflow [d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp line 1585] nsBlockReflowContext::DoReflowBlock [d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp line 581] (6735149) Comments: I am downloading Pilot theme in the preference dialog. (6732632) Comments: Trying to load the ie theme (6730034) Comments: Installing Kzilla theme from themes.mozdev.org. (6729922) Comments: Installing the skypilot theme from mozdev.org (6703290) Comments: Just downloading and trying a new theme... I don't know exactly what happened since it's my first time. (6680437) Comments: i was downloading a theme for mozilla (6680274) Comments: Trying to install a new skin (6641382) Comments: I was installing a mozilla theme that I had downloaded when it crashed. (6626771) Comments: chose from mozdev website: download and install pinball theme.it downloaded very slow (>10mins) and when it was at 100% mozilla crashed and all mozilla windows closed... (6622992) Comments: was installing lo-fi classic theme This was orginally thought to be a problem with dynamic theme switching, but that is clearly not the case.
Summary: Trunk M098 N621 crashes switching themes [@ nsHTMLReflowState::DetermineFrameType] → Trunk N621 M1RC3 crashes installing themes [@ nsHTMLReflowState::DetermineFrameType]
Using the latest line numbers in the stack for a M1RC3 crash, the crash seems to happening somewhere in this code: 373 nsCSSFrameType 374 nsHTMLReflowState::DetermineFrameType(nsIFrame* aFrame, 375 const nsStyleDisplay* aDisplay) 376 { 377 nsCSSFrameType frameType; 378 379 // Get the frame state 380 nsFrameState frameState; 381 aFrame->GetFrameState(&frameState); I'm guessing the crash is happening at line 381...but not sure. Here are the parameter values: nsHTMLReflowState::DetermineFrameType aFrame = 0x05a83140 (*aFrame) = Data not available aDisplay = 0x00000000 (*aDisplay) = Data not available frameType = 0 (0x00000000) And the register values if that helps: Registers: EAX: 00000000 EBX: 0012bbc8 ECX: 0594a3a0 EDX: 0000004c ESI: 0012b7b8 EDI: 0012b9d8 ESP: 0012b754 EBP: 0012b754 EIP: 603da014 cf PF af ZF sf of IF df nt RF vm IOPL: 0 CS: 001b DS: 0023 SS: 0023 ES: 0023 FS: 003b GS: 0000
Whiteboard: (jp)
Removing nsbeta1- and renominating. Comment #8 no longer applies, since we are crashing despite the dynamic theme switching being turned off. Updating summary with M100 since this is now a topcrasher with Mozilla 1.0 as well.
Keywords: nsbeta1-nsbeta1
Summary: Trunk N621 M1RC3 crashes installing themes [@ nsHTMLReflowState::DetermineFrameType] → Trunk N621 M100 crashes installing themes [@ nsHTMLReflowState::DetermineFrameType]
Ok this bug is really about two separate issues: 1) Dynamically switching between modern and classic. This no longer fails because we turned off dynamic switching. 2) Installing third party themes. These themes will fail unless they have been modified to work with N7.0 PR1 or Mozilla1.0. Old 6.x and pre Moz1.0 themes are *not* compatible with N7 and Mozilla1.0 On the N7 theme park it states: Themes for Netscape 7.0 will be available at final release of the product. Users testing the Netscape 7.0 Preview Release 1 can choose between the Modern and Classic themes already installed with the Preview Release. Please revisit this site when the final version of Netscape 7.0 is released. Thank you. We can't expect layout to protect itself against crashes caused by users loading old incompatible themes. We should prevent users from installing incompatible themes in the first place, which is a bug that doesn't belong in layout.
Assignee: attinasi → shliang
Status: ASSIGNED → NEW
Component: Layout → Themes
QA Contact: petersen → pmac
-> topcrash- by Talkback triage team
Keywords: topcrash+topcrash-
Nav triage team: nsbeta1-
Keywords: nsbeta1nsbeta1-
(In reply to comment #17) Says it and there are no crash reports in the talkback db with such a stack signature. Problems seems to be fixed since Mozilla 1.0. Resolving. Feel free to reopen if you think this bug should still be open and affects current builds.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
Version: Trunk → 1.0 Branch
Product: Core → SeaMonkey
Keywords: testcase
Marking as fixed based on 5 years of WORKSFORME
Resolution: WORKSFORME → FIXED
Crash Signature: [@ nsHTMLReflowState::DetermineFrameType]
You need to log in before you can comment on or make changes to this bug.