Closed
Bug 1242459
Opened 9 years ago
Closed 9 years ago
Replace dump() in testing/marionette/actions.js with logger
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
testing/marionette/actions.js:118 uses dump() to log debug information. This ought to be replaced with a logger instance:
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/actions.js#118
Note that this might be a bit tricky because this file is loaded using loadJsSubscript, and not Cu.import.
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [good first bug][lang=js]
|
|
Assignee | |
Comment 1•9 years ago
|
||
I investigated this a bit further, and it’s not a good first bug. As mentioned before, it requires rewriting testing/marionette/actions.js to a JS module.
Whiteboard: [good first bug][lang=js]
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Keywords: ateam-marionette-server
|
|
Assignee | |
Comment 2•9 years ago
|
||
Turns testing/marionette/actions.js into a JS module.
Review commit: https://reviewboard.mozilla.org/r/32653/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32653/
Attachment #8712798 -
Flags: review?(dburns)
|
||
Updated•9 years ago
|
Attachment #8712798 -
Flags: review?(dburns) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8712798 [details]
MozReview Request: Bug 1242459 - Replace dump() with logger in actions.js; r?automatedtester
https://reviewboard.mozilla.org/r/32653/#review29433
::: testing/marionette/actions.js:120
(Diff revision 1)
> - ") relative to the viewport\n" +
> + "relative to the viewport, " +
can you update this to `` so that it is in keeping with the rest. It will have no affect but just looks better.
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•