Closed
Bug 1244042
Opened 9 years ago
Closed 9 years ago
[B2G] Marionette JavaScript Error: "TypeError: actions is undefined" {file: "chrome://marionette/content/driver.js" line: 141}
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
|
(deleted),
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a follow-up of Bug #1242459 +++
Since the JSMs of b2g share the same global scope [1], anything the subscript wants to export needs to be set as a member of `this` [2].
[1] Please see bug 798491.
[2] Please see bug 807478 comment 38.
|
Assignee | |
Updated•9 years ago
|
Blocks: emu-x86-kk-tests
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8713526 [details] [diff] [review]
Patch, v1
Review of attachment 8713526 [details] [diff] [review]:
-----------------------------------------------------------------
Hi :ato, may I have your review? Please see comment #0 for the details and try result is on the way. Thank you.
Attachment #8713526 -
Flags: review?(ato)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8713526 [details] [diff] [review]
Patch, v1
LGTM. Please submit patches using MozReview next time.
Attachment #8713526 -
Flags: review?(ato) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Andreas Tolfsen (:ato) from comment #3)
> Comment on attachment 8713526 [details] [diff] [review]
> Patch, v1
>
> LGTM. Please submit patches using MozReview next time.
The review mercurial server is down, so I use bugzilla for review at this time. Thank you.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Try result looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d48cd039eb6&group_state=expanded
|
|
||
Comment 6•9 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> (In reply to Andreas Tolfsen (:ato) from comment #3)
> > Comment on attachment 8713526 [details] [diff] [review]
> > Patch, v1
> >
> > LGTM. Please submit patches using MozReview next time.
>
> The review mercurial server is down, so I use bugzilla for review at this
> time. Thank you.
Oh I didn’t know. Please ship.
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•