The pref services.sync.syncedTabsUIRefresh is set to true by default on Nightly and false for other releases. When the pref is true: > Synced Tabs toolbar menu item and sidebar > - Toolbar item: Sync Now, Sidebar toggle > - History menus: Expands Synced Tabs toolbar menu item, wherever it is > - View›Sidebar menu: Synced Tabs When the pref is false: > has toolbar menu item and about:sync-tabs > - Toolbar item: Sync Now; no Sidebar toggle > - History menus: about:sync-tabs (Tabs From Other Devices) > - View›Sidebar menu: No Synced Tabs

The sheriffs usually close on merge.

[Tracking Requested - why for this release]:

Comment on attachment 8712953 [details] [diff] [review] Create a pref to enable/disable the Synced Tabs UI refresh and enable it for Nightly Approval Request Comment [Feature/regressing bug #]: 1201331 [User impact if declined]: Users will have no UI affordance to see their full list of synced tabs or to filter them [Describe test coverage new/current, TreeHerder]: N/A [Risks and why]: small, adds a pref to hide a menu item [String/UUID change made/needed]: N/A

Comment on attachment 8712953 [details] [diff] [review] Create a pref to enable/disable the Synced Tabs UI refresh and enable it for Nightly [Triage Comment] I think we want that in 46 too. Taking it to be able to disable the pref it is not ready. Should be in 45 beta 2.

fails to apply to aurora like: grafting 326037:07cd13fd89db "Bug 1243591 - Create a pref to enable/disable the Synced Tabs UI refresh and enable it for Nightly r=markh" merging browser/app/profile/firefox.js merging browser/base/content/browser-sets.inc merging browser/base/content/browser.js warning: conflicts while merging browser/base/content/browser-sets.inc! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue

Here's one that merges cleanly with Aurora.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1243591#c9

Hi Carsten, I've uploaded a new patch that applies cleanly in Aurora. Let me know if I should do anything else.

(In reply to Zachary Carter [:zaach] from comment #11) > Hi Carsten, I've uploaded a new patch that applies cleanly in Aurora. Let me > know if I should do anything else. no, all fine - https://hg.mozilla.org/releases/mozilla-aurora/rev/3f4dbceab265 thanks!

backed out from aurora and beta for test bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=1856998&repo=mozilla-aurora

Fixed for 45/46: https://bugzilla.mozilla.org/show_bug.cgi?id=1243591#c15

Zach will be pushing a new patch to try

try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c896735a265b

zach are the leaks from your push ?

I couldn't find any indicators that it was caused by this patch. There's one test that references the menuitem affected by the patch (here: https://hg.mozilla.org/releases/mozilla-aurora/file/tip/browser/components/customizableui/test/browser_946320_tabs_from_other_computers.js#l23), but the test doesn't actually trigger the code path that would be affected.

landed on aurora -> https://hg.mozilla.org/releases/mozilla-aurora/rev/635e6dd86b88

A few issues on the latest nightly: (In reply to Zachary Carter [:zaach] from comment #0) > > - Toolbar item: Sidebar toggle 1. Are you talking about "Menu Panel/Synced tabs/View synced tabs sidebar" option? > > - View›Sidebar menu: Synced Tabs 2. This is not displayed in a clean profile, only after I click first on the 'synced tabs' button 3. different size for history/synced tabs vs synced tabs - http://i.imgur.com/C6iSDoj.png Thoughts?

(In reply to Paul Silaghi, QA [:pauly] from comment #23) > A few issues on the latest nightly: > (In reply to Zachary Carter [:zaach] from comment #0) > > > - Toolbar item: Sidebar toggle > 1. Are you talking about "Menu Panel/Synced tabs/View synced tabs sidebar" > option? > > > > - View›Sidebar menu: Synced Tabs > 2. This is not displayed in a clean profile, only after I click first on the > 'synced tabs' button > It does display as an option after you sign into Sync, which is good. > 3. different size for history/synced tabs vs synced tabs - > http://i.imgur.com/C6iSDoj.png > Thoughts? Bug 1241141.

Confirm that services.sync.syncedTabsUIRefresh pref is true by default in Firefox 47.0a1 and false in Firefox 46.0a2 and Firefox 45 beta 7. Verified fixed on Firefox 47.0a1 (216-02-18), Firefox 46.0a2 (2016-02-18) and Firefox 45 beta 7 (20160218171844) under Ubuntu 12.04 64-bit, Mac OS X 10.9.5 and Windows 10 64-bit. All the expected results are met according to the pref value and the Firefox version.