Closed Bug 1243595 Opened 9 years ago Closed 9 years ago

Add session/usage data to telemetry pings

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 2 obsolete files)

MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt
(deleted), text/x-review-board-request
ahunt
: review+
Details
MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt
(deleted), text/x-review-board-request
ahunt
: review+
Details
MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt
(deleted), text/x-review-board-request
ahunt
: review+
Details
From the mobile telemetry documentation: "usage": [<pos integer>, <pos integer>], // array of total usage time in seconds since last ping and // foreground session count, e.g.: [156, 2] Since we're adding counts since last ping, we need bug 1243585 to land first.
Blocks: core-ping
No longer blocks: ut-android
No longer depends on: core-ping
As we discussed in today's meeting: we should break this into two fields instead of one: * session time in seconds (aggregate) * number of sessions We'll see how that feels and change it if necessary.
Summary: (telemetry v4) Add session/usage data to telemetry pings → Add session/usage data to telemetry pings
Assignee: nobody → michael.l.comella
(In reply to Michael Comella (:mcomella) from comment #2) > As we discussed in today's meeting: we should break this into two fields > instead of one: > * session time in seconds (aggregate) > * number of sessions Georg, do you have opinions on field names? I propose: * sessionCount * sessionDuration
Flags: needinfo?(gfritzsche)
Georg, also, for the initial ping, the first measurements will be 0 & 0 – would we prefer to omit the field or leave it as 0 & 0?
(In reply to Michael Comella (:mcomella) from comment #4) > Georg, also, for the initial ping, the first measurements will be 0 & 0 – > would we prefer to omit the field or leave it as 0 & 0? For simplicity, I'd vote just leave it 0, 0.
Comment on attachment 8753581 [details] MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53360/diff/1-2/
Comment on attachment 8753582 [details] MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53362/diff/1-2/
Comment on attachment 8753583 [details] MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53364/diff/1-2/
Comment on attachment 8753581 [details] MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53360/diff/2-3/
Attachment #8753581 - Attachment description: MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt → MozReview Request: Bug 1243595 - Only log telemetry in release builds. r=grisha
Attachment #8753581 - Flags: review?(ahunt) → review?(gkruglov)
Review commit: https://reviewboard.mozilla.org/r/53722/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53722/
Attachment #8753581 - Attachment description: MozReview Request: Bug 1243595 - Only log telemetry in release builds. r=grisha → MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt
Attachment #8754104 - Flags: review?(ahunt)
Attachment #8754105 - Flags: review?(ahunt)
Attachment #8753581 - Flags: review?(gkruglov) → review?(ahunt)
Comment on attachment 8753581 [details] MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53360/diff/3-4/
(In reply to Michael Comella (:mcomella) from comment #3) > (In reply to Michael Comella (:mcomella) from comment #2) > > As we discussed in today's meeting: we should break this into two fields > > instead of one: > > * session time in seconds (aggregate) > > * number of sessions > > Georg, do you have opinions on field names? I propose: > * sessionCount > * sessionDuration Keeping with the shorter field names we tried to establish, how about: * sessions * durations
Flags: needinfo?(gfritzsche)
(In reply to Georg Fritzsche [:gfritzsche] from comment #17) > > Georg, do you have opinions on field names? I propose: > > * sessionCount > > * sessionDuration > > Keeping with the shorter field names we tried to establish, how about: > * sessions > * durations To be fair though, i don't have a strong opinion about this. If "saving bytes" is still a concern then we should use shorter names where reasonable though.
Attachment #8753581 - Flags: review?(ahunt) → review+
Comment on attachment 8753581 [details] MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt https://reviewboard.mozilla.org/r/53360/#review50670
Comment on attachment 8754104 [details] MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt https://reviewboard.mozilla.org/r/53722/#review50672
Attachment #8754104 - Flags: review?(ahunt) → review+
Attachment #8754105 - Flags: review?(ahunt) → review+
Comment on attachment 8754105 [details] MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt https://reviewboard.mozilla.org/r/53724/#review50674
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: