Closed Bug 1245505 Opened 9 years ago Closed 9 years ago

Last sync date not localized in synced tabs button tooltip

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Version:
45 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: stef, Assigned: eoger)

References

Details

Attachments

(1 file, 2 obsolete files)

bug-1245505.patch
(deleted), patch
eoger
: review+
Details | Diff | Splinter Review
https://hg.mozilla.org/releases/mozilla-beta/file/default/services/sync/locales/en-US/sync.properties#l9 OS X 10.11, Firefox 45.0b2 pl Currently: "Ostatnia synchronizacja: Wed 15:55" Should be: "Ostatnia synchronizacja: środa, 15:55" (or something similar) Apart from not being localized this could also mislead and confuse users even more when there are short weekday names collisions between installed locale and English.
Attached patch bug-1245505.patch (obsolete) (deleted) — — Splinter Review
Let's use something more standard than toLocaleFormat.
Assignee: nobody → edouard.oger
Status: NEW → ASSIGNED
Attachment #8715329 - Flags: review?(markh)
(In reply to Edouard Oger [:eoger] from comment #1) > Let's use something more standard than toLocaleFormat. Yes, that would work (see also bug 409832 comment 10) but could we please use normal ("long") form for the weekday as we do not really have a need to shorten it?
Comment on attachment 8715329 [details] [diff] [review] bug-1245505.patch Review of attachment 8715329 [details] [diff] [review]: ----------------------------------------------------------------- Edouard's back! \o/ LGTM, but please change the weekday to "long" as mentioned in comment 2
Attachment #8715329 - Flags: review?(markh) → review+
Attached patch bug-1245505.patch (obsolete) (deleted) — — Splinter Review
Here we go, with the long weekday. Carrying r+ forward. Nice to see too Mark!
Attachment #8715329 - Attachment is obsolete: true
Attachment #8715781 - Flags: review+
Attached patch bug-1245505.patch (deleted) — — Splinter Review
Nitpick I forgot a semicolon
Attachment #8715781 - Attachment is obsolete: true
Attachment #8715783 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d0badf8b22b0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: