Alexandre Poirot [:ochameau] Assignee
	Description • 9 years ago

Today, we mix both Cu.import and require for loading Services.
This is disturbing. Either we consider that require("Services") is really useful and use it everywhere, or we stick with Cu.import(). But we shouldn't have both in our codebase.

	Alexandre Poirot [:ochameau] Assignee
	Comment 1 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee1182bc4287

	Alexandre Poirot [:ochameau] Assignee
	Comment 2 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23068cb42858

	Alexandre Poirot [:ochameau] Assignee
	Comment 3 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=633f590780fd

	Alexandre Poirot [:ochameau] Assignee
	Comment 4 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef118d4303e1

	Alexandre Poirot [:ochameau] Assignee
	Comment 5 • 9 years ago

Let's try to wrap up with this refactoring patch I keep rebasing...

	Alexandre Poirot [:ochameau] Assignee
	Comment 6 • 9 years ago

Comment on attachment 8722927 [details] [diff] [review]
patch v1

Review of attachment 8722927 [details] [diff] [review]:
-----------------------------------------------------------------

This is a quite dump patch...
Sometimes I have to move around the precise line where I do a require(), as require is often available a few lines after.
Sometimes I already replace lazyImporter with require() as there isn't much value in lazy loading this module!

	Alexandre Poirot [:ochameau] Assignee
	Comment 7 • 9 years ago

Here is a try build with this patch (and many others)
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=848118726eaa&exclusion_profile=false

	Alexandre Poirot [:ochameau] Assignee
	Comment 8 • 9 years ago

Even greener try, with even more patches:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6989b13865cb

	Alexandre Poirot [:ochameau] Assignee
	Comment 9 • 9 years ago

Rebased.

	Alexandre Poirot [:ochameau] Assignee
	Comment 10 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/93f0d5522db1bcdb8a7c839930025a2d2f37b443
Bug 1245530 - Use require(Services) instead of Cu.import(Services.jsm). r=jryans

	Carsten Book [:Tomcat]
	Comment 11 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/93f0d5522db1