Closed Bug 12520 Opened 25 years ago Closed 25 years ago

{css3} GFX select elements need to be able to turn off text selection

Categories

(Core :: DOM: Selection, defect, P3)

All
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: rods, Assigned: pierre)

References

Details

(Keywords: css3)

Attachments

(1 file)

text selection is enabled inside optgroups and option element frames and I need
to have a way to turn this off. Peterl mentioned that a finer level of control
over selection will be needed for CSS3. So the ability to turn this off works
with where CSS is going.
Blocks: 12521
Blocks: 12523
I guess we need to be able to turn selection on and off for any given frame.
rod, could you please describe why this is a blocker, so we can prioritize it
correctly?  thanks.
Blocks: 12711
This is a beta blocker, it provides improper and confusing feedback when using
the select control
Status: NEW → ASSIGNED
Target Milestone: M11
what is a select control? and can someone help me on the css part. i would be
glad to have frames talk to the css and draw selection or not if thats whats
wanted. should we also stop people from Selecting the frame at all? selection
will still go around it though.
mjudge: A 'select control' is a combo box, just like this that are on this very
form for the Platform, OS, Priority, etc... fields. It's called a 'select'
control because in HTML it is instantiated by using the <SELECT> element.

As for the CSS stuff, I'm ccing Peter who should be able to fill you in on how
CSS3 decides whether or not something should be selectable.

peterl: The problem is that selection has to be disabled/enabled on a per-frame
basis, otherwise we have the comic situation of being able to select the text
in a <select> element. The recent CSS3 UI draft has a few properties related to
this. Could you relay with mjudge to work out if we are going to use these
properties or if we should do something else?

The relevant part of the DRAFT document in question is:
   http://www.w3.org/TR/1999/WD-css3-userint-19990916#user-select

This is a beta blocker.
Blocks: 14783
Summary: GFX select elements need to be able to turn off text selection → {css3} GFX select elements need to be able to turn off text selection
The CSS3 properties to control selection have been implemented for a while now.
See the nsStyleUserInterface struct from the style context.
It should work already. GetMutableStyleData(eStyleStruct_UserInterface) gives you

access to mUserSelect (then look for 'user-select' in nsStyleConst.h)
Actually you should be using GetStyleData(eStyleStruct_UserInterface) for read
access to style data. Consider GetMutableStyleData deprecated.
I don't see the text selection happening in a select widget, so is this fixed?
*** Bug 12523 has been marked as a duplicate of this bug. ***
It isn't fixed for drop-down widgets that have native scrollbars. Once the
select is converted to use GFX scrollbars this may go away.
No longer blocks: 14783
[Note to self: please also verify bugs marked as duplicate of this bug, while
verifying this bug.]
Target Milestone: M11 → M14
Blocks: 17907
Assignee: mjudge → pierre
Status: ASSIGNED → NEW
reassigned to myself
Blocks: 18951
Attached file testcase (deleted) —
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
It's fixed as shown in the attached testcase. The XPToolkit folks still have to
fix the remaining selection problems which can be found in html.css and other
places (see the bugs depending on this one).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
With the latest nightly build (~19991130) the test case does not work.
I am assuming that "working" means that it should not be possible to select
the H2 in the test case, and yet it is. (The cursor changing works, but the
selection model used for both the H1 and H2 is 'user-select:text'.)

Reopening.
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Fixed again. A previous checkin assumed that mUserSelect was a bit field but it's
not. See http://www.w3.org/TR/1999/WD-css3-userint-19990916#user-select for more
info.
Status: RESOLVED → VERIFIED
Woohoo! It works! Cool.

Tested with Win32 AppRunner 1999120208.
Keywords: css3
No longer blocks: 17907
No longer blocks: 18951
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: