Closed
Bug 12520
Opened 25 years ago
Closed 25 years ago
{css3} GFX select elements need to be able to turn off text selection
Categories
(Core :: DOM: Selection, defect, P3)
Tracking
()
VERIFIED
FIXED
M14
People
(Reporter: rods, Assigned: pierre)
References
Details
(Keywords: css3)
Attachments
(1 file)
(deleted),
text/html
|
Details |
text selection is enabled inside optgroups and option element frames and I need to have a way to turn this off. Peterl mentioned that a finer level of control over selection will be needed for CSS3. So the ability to turn this off works with where CSS is going.
Reporter | ||
Comment 1•25 years ago
|
||
I guess we need to be able to turn selection on and off for any given frame.
rod, could you please describe why this is a blocker, so we can prioritize it correctly? thanks.
Reporter | ||
Comment 3•25 years ago
|
||
This is a beta blocker, it provides improper and confusing feedback when using the select control
what is a select control? and can someone help me on the css part. i would be glad to have frames talk to the css and draw selection or not if thats whats wanted. should we also stop people from Selecting the frame at all? selection will still go around it though.
Comment 5•25 years ago
|
||
mjudge: A 'select control' is a combo box, just like this that are on this very form for the Platform, OS, Priority, etc... fields. It's called a 'select' control because in HTML it is instantiated by using the <SELECT> element. As for the CSS stuff, I'm ccing Peter who should be able to fill you in on how CSS3 decides whether or not something should be selectable. peterl: The problem is that selection has to be disabled/enabled on a per-frame basis, otherwise we have the comic situation of being able to select the text in a <select> element. The recent CSS3 UI draft has a few properties related to this. Could you relay with mjudge to work out if we are going to use these properties or if we should do something else? The relevant part of the DRAFT document in question is: http://www.w3.org/TR/1999/WD-css3-userint-19990916#user-select This is a beta blocker.
Updated•25 years ago
|
Summary: GFX select elements need to be able to turn off text selection → {css3} GFX select elements need to be able to turn off text selection
Comment 6•25 years ago
|
||
The CSS3 properties to control selection have been implemented for a while now. See the nsStyleUserInterface struct from the style context.
Assignee | ||
Comment 7•25 years ago
|
||
It should work already. GetMutableStyleData(eStyleStruct_UserInterface) gives you access to mUserSelect (then look for 'user-select' in nsStyleConst.h)
Comment 8•25 years ago
|
||
Actually you should be using GetStyleData(eStyleStruct_UserInterface) for read access to style data. Consider GetMutableStyleData deprecated.
Comment 9•25 years ago
|
||
I don't see the text selection happening in a select widget, so is this fixed?
Comment 10•25 years ago
|
||
*** Bug 12523 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 11•25 years ago
|
||
It isn't fixed for drop-down widgets that have native scrollbars. Once the select is converted to use GFX scrollbars this may go away.
Comment 12•25 years ago
|
||
[Note to self: please also verify bugs marked as duplicate of this bug, while verifying this bug.]
Updated•25 years ago
|
Target Milestone: M11 → M14
Assignee | ||
Updated•25 years ago
|
Assignee: mjudge → pierre
Status: ASSIGNED → NEW
Assignee | ||
Comment 13•25 years ago
|
||
reassigned to myself
Assignee | ||
Comment 14•25 years ago
|
||
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•25 years ago
|
||
It's fixed as shown in the attached testcase. The XPToolkit folks still have to fix the remaining selection problems which can be found in html.css and other places (see the bugs depending on this one).
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Updated•25 years ago
|
Resolution: FIXED → ---
Comment 16•25 years ago
|
||
With the latest nightly build (~19991130) the test case does not work. I am assuming that "working" means that it should not be possible to select the H2 in the test case, and yet it is. (The cursor changing works, but the selection model used for both the H1 and H2 is 'user-select:text'.) Reopening.
Assignee | ||
Updated•25 years ago
|
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•25 years ago
|
||
Fixed again. A previous checkin assumed that mUserSelect was a bit field but it's not. See http://www.w3.org/TR/1999/WD-css3-userint-19990916#user-select for more info.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 18•25 years ago
|
||
Woohoo! It works! Cool. Tested with Win32 AppRunner 1999120208.
You need to log in
before you can comment on or make changes to this bug.
Description
•