Except for test_unknownContentType_dialog_layout.xul, that is disabled unnecessarily, we should just remove other test code that runs only in legacy configurations where MOZ_JSDOWNLOADS is not defined.

Review commit: https://reviewboard.mozilla.org/r/38199/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38199/

Comment on attachment 8726726 [details] MozReview Request: Bug 1253585 - Remove legacy downloads test code and re-enable test_unknownContentType_dialog_layout.xul. r=mak https://reviewboard.mozilla.org/r/38199/#review35299 LGTM. My only "complain" is that among these tests there may be some that could be useful if converted to cover the new API... but not a good enough reason to keep them around. ::: toolkit/components/downloads/test/unit/head_download_manager.js (Diff revision 1) > -Services.prefs.setBoolPref("browser.download.manager.showAlertOnComplete", false); do we have a bug filed to remove all the remaining references to browser.download.manager.showAlertOnComplete and in general old DM prefs?

(In reply to Marco Bonardo [::mak] from comment #3) > My only "complain" is that among these tests there may be some that could be > useful if converted to cover the new API... but not a good enough reason to > keep them around. I agree. I think most tests are fully covered under the new API, that has also many other tests that weren't present originally. If there are any remaining cases that are not covered, they are probably edge cases, and we can easily add back the tests when touching the related code. > do we have a bug filed to remove all the remaining references to > browser.download.manager.showAlertOnComplete and in general old DM prefs? No, good point, I just filed bug 1254558.

Is there something QA can do here? If not, please set the [qe-verify-] flag. Thanks.

No, this was meant to be "qe-verify-". Thanks!