Closed Bug 1253858 Opened 9 years ago Closed 9 years ago

Turn off mochitest-push on esr45

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: aselagea)

References

Details

Attachments

(2 files)

bug_1253858.patch
(deleted), patch
rail
: review+
RyanVM
: feedback+
aselagea
: checked-in+
Details | Diff | Splinter Review
bug_1253858_tests_diff.txt
(deleted), text/plain
Details
Bug 1232029 disabled Push and Service Workers for esr45. Given that the test suite is extremely flaky as it is, is there any reason to run the tests at this point or can we turn them off and save some resources?
I should also point out that M(p) is hidden by default on Treeherder, which means that it's effectively unsheriffed as well.
+1 to turning the tests off. We're working on a plan to remove the dependency on the production server, but that's a ways out. No need to spend cycles on tests for a disabled feature.
Assignee: nobody → alin.selagea
Attached patch bug_1253858.patch (deleted) — — Splinter Review
Attachment #8727779 - Flags: review?(ryanvm)
Attached file bug_1253858_tests_diff.txt (deleted) —
Also attached the tests diff file.
Comment on attachment 8727779 [details] [diff] [review] bug_1253858.patch Looks fine to me, but I'm not a peer of this code.
Attachment #8727779 - Flags: review?(ryanvm)
Attachment #8727779 - Flags: review?(rail)
Attachment #8727779 - Flags: feedback+
Comment on attachment 8727779 [details] [diff] [review] bug_1253858.patch Review of attachment 8727779 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla-tests/config.py @@ +2766,5 @@ > + if platform in BRANCHES[branch]['platforms']: > + if slave_platform in BRANCHES[branch]['platforms'][platform]: > + x = BRANCHES[branch]['platforms'][platform][slave_platform] > + x['opt_unittest_suites'] = [i for i in x['opt_unittest_suites'] if i not in MOCHITEST_PUSH ] > + x['debug_unittest_suites'] = [i for i in x['debug_unittest_suites'] if i not in MOCHITEST_PUSH ] a nit: no space before ]
Attachment #8727779 - Flags: review?(rail) → review+
Comment on attachment 8727779 [details] [diff] [review] bug_1253858.patch Deleted the spaces and landed the patch. Thanks!
Attachment #8727779 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: