Closed
Bug 1253871
Opened 9 years ago
Closed 9 years ago
L10N repacks should use martools from en-US build, not from latest dir
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
rail
:
review+
rail
:
checked-in+
|
Details |
(deleted),
text/x-review-board-request
|
jlund
:
review+
rail
:
checked-in+
|
Details |
See https://bugzilla.mozilla.org/show_bug.cgi?id=1253749#c6 for the details.
L10N builds currently use mar tools from *aurora*'s latest directory, because we don't have nightly builds on the beta/release/esr branches.
At the same time every CI build in release promotion generates martools.
We should teach desktop_l10n.py how to use en-US generated martools - we already pass EN_US_BINARY_URL to the script.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rail
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8728741 -
Flags: review?(jlund)
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/39081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39081/
Attachment #8728742 -
Flags: review?(jlund)
Updated•9 years ago
|
Attachment #8728742 -
Flags: review?(jlund)
Comment 3•9 years ago
|
||
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release
https://reviewboard.mozilla.org/r/39081/#review35747
::: testing/mozharness/scripts/desktop_l10n.py:266
(Diff revision 1)
> + for prop in ['mar_tools_url']:
this looks weird. is this because you don't want to overwrite other properties?
Comment 4•9 years ago
|
||
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release
https://reviewboard.mozilla.org/r/39081/#review35749
Attachment #8728742 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release
https://hg.mozilla.org/releases/mozilla-beta/rev/8867739057e6
Need to graft to other branches too
Attachment #8728742 -
Flags: checked-in+
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8728742 [details]
MozReview Request: Bug 1253871 - L10N repacks should use martools from en-US build, not from latest dir r=jlund a=release
https://hg.mozilla.org/integration/mozilla-inbound/rev/504e0b786d38
https://hg.mozilla.org/releases/mozilla-aurora/rev/aaa3cdd45ed3
https://hg.mozilla.org/releases/mozilla-esr45/rev/904e2a9eb070
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8728741 [details]
releasetasks patch
r+ed in the PR
Attachment #8728741 -
Flags: review?(jlund)
Attachment #8728741 -
Flags: review+
Attachment #8728741 -
Flags: checked-in+
Comment 9•9 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•