Closed
Bug 1254967
Opened 9 years ago
Closed 9 years ago
MSVC 2015 build fails with C1083
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
(deleted),
patch
|
poiru
:
review+
|
Details | Diff | Splinter Review |
28:19.35 host_guid_string.obj
28:20.10 Microsoft(R) C/C++ Optimizing Compiler Version 19.00.23506 for x64
28:20.10 Copyright (C) Microsoft Corporation. All rights reserved.
28:20.10
28:20.10 dia_util.cc
28:20.10 f:/m/mozilla-central/toolkit/crashreporter/google-breakpad/src\common/windows/dia_util.h(35): fatal error C1083: include ファイルを開けません。'dia2.h':No such file or directory
28:20.11
28:20.12 In the directory /f/m/mozilla-central/obj-x86_64-pc-mingw32/toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms
28:20.12 The following command failed to execute properly:
28:20.12 f:/m/mozilla-central/obj-x86_64-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl -Fohost_dia_util.obj -c -DNDEBUG=1 -DTRIMMED=1 -O2 -EHsc -MD -Fdhost_dia_util.pdb -If:/m/mozilla-central/toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms -If:/m/mozilla-central/obj-x86_64-pc-mingw32/toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms -If:/m/mozilla-central/toolkit/crashreporter/google-breakpad/src -If:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/include -If:/m/mozilla-central/obj-x86_64-pc-mingw32/dist/include/nspr f:/m/mozilla-central/toolkit/crashreporter/google-breakpad/src/common/windows/dia_util.cc
28:20.14 f:/m/mozilla-central/config/rules.mk:911: recipe for target 'host_dia_util.obj' failed
28:20.14 mozmake.EXE[5]: *** [host_dia_util.obj] Error 1
28:20.15 f:/m/mozilla-central/config/recurse.mk:71: recipe for target 'toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms/host' failed
28:20.15 mozmake.EXE[4]: *** [toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms/host] Error 2
28:20.15 mozmake.EXE[4]: *** Waiting for unfinished jobs....
28:20.43 TestParser.cpp
28:20.45 stagefright_gtest.lib.desc
28:21.80 Unified_cpp_caps_tests_gtest0.cpp
28:21.82 caps_tests_gtest.lib.desc
28:21.88 Unified_cpp_tests_gtest0.cpp
28:21.90 tools_profiler_tests_gtest.lib.desc
28:22.81 Unified_cpp_tests_gtest0.cpp
28:22.83 devtoolstests.lib.desc
28:25.67 Unified_cpp_dom_base_test_gtest0.cpp
28:25.69 dom_base_test_gtest.lib.desc
28:25.76 Unified_cpp_dom_media_gtest1.cpp
28:30.75 Unified_cpp_dom_media_gtest0.cpp
28:30.76 dom_media_gtest.lib.desc
28:30.85 f:/m/mozilla-central/config/recurse.mk:32: recipe for target 'compile' failed
28:30.85 mozmake.EXE[3]: *** [compile] Error 2
28:30.85 f:/m/mozilla-central/config/rules.mk:557: recipe for target 'default' failed
28:30.85 mozmake.EXE[2]: *** [default] Error 2
28:30.85 f:/m/mozilla-central/client.mk:419: recipe for target 'realbuild' failed
28:30.85 mozmake.EXE[1]: *** [realbuild] Error 2
28:30.85 client.mk:181: recipe for target 'build' failed
28:30.85 mozmake.EXE: *** [build] Error 2
28:30.89 16 compiler warnings present.
2
Assignee | ||
Comment 1•9 years ago
|
||
Reverting bug 623183 fixed the issue.
Comment 2•9 years ago
|
||
Do you have the latest version Mozilla Build (2.1.0)?
Assignee | ||
Comment 3•9 years ago
|
||
Yes. (I read VERSION file on the install directory.)
Assignee | ||
Comment 4•9 years ago
|
||
Although $(VSInstallDir)\DIA SDK\include has dia2.h, MozillaBuild doesn't add it to $INCLUDE.
Assignee | ||
Comment 5•9 years ago
|
||
MozillaBuild 2.1 does not contain the bug 1240300 change yet.
Comment 6•9 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #5)
> MozillaBuild 2.1 does not contain the bug 1240300 change yet.
Oh! I was under the impression that we released a new MozillaBuild.
Depends on: 1240300
Updated•9 years ago
|
Depends on: MozillaBuild2.2
Comment 7•9 years ago
|
||
Could we just do this in configure/moz.build instead?
Comment 8•9 years ago
|
||
Given the newfound urgency in getting switched over to MSVC2015, I can try to prioritize getting a final 2.2 release out sooner rather than later as well.
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
When will MozillaBuild 2.2 be released? If it is not in a few days, please review the patch.
Updated•9 years ago
|
Attachment #8728463 -
Flags: review?(ted) → review+
Assignee | ||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d23be50020a5a73760b1e4fe85ac06f522692ab
Bug 1254967 - Actually test if dia2.h exists instead of assuming the existence. r=poiru
Comment 12•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 13•9 years ago
|
||
We should probably have just used some Python to detect the DIA SDK dir and add it to LOCAL_INCLUDES. Currently this makes it so you can't run `mach buildsymbols` locally with VS2015 unless you manually set INCLUDE.
You need to log in
before you can comment on or make changes to this bug.
Description
•