bug 575519 is a band-aid for an annoying situation. We have a checked-in binary of dump_syms.exe on Windows, because it requires VC++ Pro to build it (but it will run with VC++ Express). However, it depends on the specific version of the DIA DLLs installed with the compiler, so the VC8 binary that's checked in won't work if you don't have VC8 installed. The band-aid is just to add a VC9 copy, but then we're still broken if someone has only VC10 installed. We should just add a configure test to see if we can build it, and if so, build a local copy instead of relying on the checked-in binary. That way, if a user has VC++ Pro, they don't have to worry about what binaries we have in-tree.

This will compile with any version of VS2015 (even the free Community version has the DIA SDK and ATL). Note that mozilla-build does not add the DIA SDK to INCLUDE/LIB at the moment. I won't land that until we release a fixed mozilla-build.

Comment on attachment 8703424 [details] [diff] [review] Build dump_syms on Windows when using VS2015 Review of attachment 8703424 [details] [diff] [review]: ----------------------------------------------------------------- Cool, this has always bothered me! This might conflict slightly with my patches in bug 1069556, but I don't think it'll be too bad. ::: Makefile.in @@ +193,5 @@ > MAKE_SYM_STORE_ARGS := -c --vcs-info > ifdef PDBSTR_PATH > MAKE_SYM_STORE_ARGS += -i > endif > +ifeq ($(shell test $(_MSC_VER) -ge 1900; echo $$?),0) Put this test in configure somewhere and AC_SUBST a special var for it. (Alternately, just set DUMP_SYMS_BIN completely in configure and AC_SUBST it).

Comment on attachment 8726830 [details] [diff] [review] Build dump_syms on Windows when using VS2015 Review of attachment 8726830 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks! Presumably we can remove all the conditionals if we drop support for MSVC 2013 in the future?

Comment on attachment 8726830 [details] [diff] [review] Build dump_syms on Windows when using VS2015 Review of attachment 8726830 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms/moz.build @@ +6,5 @@ > + > +HostProgram('dump_syms') > + > +HOST_SOURCES += [ > + '../../../common/windows/guid_string.cc', '../../../common/windows/omap.cc' needs to be added.

Comment on attachment 8726830 [details] [diff] [review] Build dump_syms on Windows when using VS2015 Review of attachment 8726830 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/crashreporter/google-breakpad/src/tools/windows/dump_syms/moz.build @@ +6,5 @@ > + > +HostProgram('dump_syms') > + > +HOST_SOURCES += [ > + '../../../common/windows/guid_string.cc', We also need dia_util.cc from the same directory as everything else. I can confirm dump_syms builds with dia_util.cc and omap.cc added.

https://hg.mozilla.org/integration/mozilla-inbound/rev/43092fb2943cfd1dad71b9ee47775c5953bc637e Bug 623183 - Build dump_syms on Windows when using VS2015; r=ted

Since I had made the changes to add the 2 missing source files, I just figured I'd land those.