Closed
Bug 1255320
Opened 9 years ago
Closed 9 years ago
BasicCompositor does not render to cairo win32 dibsection surface on Windows
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 5 obsolete files)
|
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
BasicCompositor::CreateRenderTarget() create a similar DrawTarget that has DDB. It is not good for read back.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Updated•9 years ago
|
Blocks: unaccel-video
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Update error handling consistent to DrawTargetCairo.
Attachment #8728842 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8728894 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8728894 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8728894 -
Flags: review?(jmuizelaar)
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8728894 [details] [diff] [review]
patch - Create DrawTarget with DIB as similar DrawTarget
Review of attachment 8728894 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawTargetCairo.cpp
@@ +1755,5 @@
> + similar = cairo_win32_surface_create_with_dib(GfxFormatToCairoFormat(aFormat),
> + aSize.width, aSize.height);
> + if (cairo_surface_status(similar)) {
> + similar = nullptr;
> + gfxCriticalError(CriticalLog::DefaultOptions(Factory::ReasonableSurfaceSize(aSize))) << "Failed to create similar cairo_win32_surface! Size: " << aSize << " Status: " << cairo_surface_status(similar) << cairo_surface_status(cairo_get_group_target(mContext)) << " format " << (int)aFormat;
As discussed let's make this code common.
@@ +1759,5 @@
> + gfxCriticalError(CriticalLog::DefaultOptions(Factory::ReasonableSurfaceSize(aSize))) << "Failed to create similar cairo_win32_surface! Size: " << aSize << " Status: " << cairo_surface_status(similar) << cairo_surface_status(cairo_get_group_target(mContext)) << " format " << (int)aFormat;
> + }
> + }
> +#endif
> + if (!similar) {
else
#endif
Attachment #8728894 -
Flags: review?(jmuizelaar) → review-
|
|
Assignee | |
Comment 7•9 years ago
|
||
Attachment #8728894 -
Attachment is obsolete: true
Attachment #8729357 -
Flags: review?(jmuizelaar)
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8729357 [details] [diff] [review]
patch - Create DrawTarget with DIB as similar DrawTarget
Review of attachment 8729357 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawTargetCairo.cpp
@@ +1748,5 @@
> return target.forget();
> }
> }
>
> + cairo_surface_t* similar = nullptr;
similar doesn't need to be initialized to null
@@ +1755,5 @@
> + similar = cairo_win32_surface_create_with_dib(GfxFormatToCairoFormat(aFormat),
> + aSize.width, aSize.height);
> + } else
> +#endif
> + if (!similar) {
The if condition can be dropped.
Attachment #8729357 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
Attachment #8729357 -
Attachment is obsolete: true
Attachment #8729360 -
Flags: review?(jmuizelaar)
|
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8729360 [details] [diff] [review]
patch - Create DrawTarget with DIB as similar DrawTarget
Review of attachment 8729360 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawTargetCairo.cpp
@@ +1748,5 @@
> return target.forget();
> }
> }
>
> + cairo_surface_t* similar = nullptr;
Drop the '= nullptr;'
Attachment #8729360 -
Flags: review?(jmuizelaar) → review+
|
|
||
Updated•9 years ago
|
Summary: BasicCompositor does not rendered to cairo win32 surface with dib on Windows → BasicCompositor does not render to cairo win32 dibsection surface on Windows
|
|
Assignee | |
Comment 11•9 years ago
|
||
Apply the comment. Carry "r=jrmuizel".
Attachment #8729360 -
Attachment is obsolete: true
Attachment #8730060 -
Flags: review+
|
||
Comment 12•9 years ago
|
||
|
||
Comment 13•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•