Closed
Bug 1257277
Opened 9 years ago
Closed 9 years ago
Extend telemetry period for embedded YouTube Flash videos from FF 48 to 53
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox45 unaffected, firefox46 unaffected, firefox47 unaffected, firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox45 | --- | unaffected |
firefox46 | --- | unaffected |
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
(deleted),
patch
|
qdot
:
review+
benjamin
:
feedback+
|
Details | Diff | Splinter Review |
The YOUTUBE_REWRITABLE_EMBED_SEEN and YOUTUBE_NONREWRITABLE_EMBED_SEEN telemetry probes expire in FF 48. FF 53 is the last Nightly version of 2016 and will hit the GA channel around April 2017. The choice of version 53 is somewhat arbitrary, but long enough to get us data through the beginning of next year.
Attachment #8731366 -
Flags: review?(kyle)
Comment 1•9 years ago
|
||
Comment on attachment 8731366 [details] [diff] [review]
extend-youtube-telemetry-period.patch
Review of attachment 8731366 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, assuming I'm ok to review this while not being a metrics peer (which I think is ok since we're just changing, not adding?)
Attachment #8731366 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8731366 [details] [diff] [review]
extend-youtube-telemetry-period.patch
Review of attachment 8731366 [details] [diff] [review]:
-----------------------------------------------------------------
Benjamin, we're collecting telemetry about our YouTube Flash embed rewriter. Our probes, YOUTUBE_REWRITABLE_EMBED_SEEN and YOUTUBE_NONREWRITABLE_EMBED_SEEN, expire in FF 48, but the feature rollout was delayed so we'd like to extend the telemetry period.
FF 53 is the last Nightly version of 2016 and will hit the GA channel around April 2017. The choice of version 53 is somewhat arbitrary, but long enough to get us data through the beginning of next year. That will give us current data when we're making other product decisions about NPAPI plugins.
Attachment #8731366 -
Flags: review?(benjamin)
Comment 3•9 years ago
|
||
Comment on attachment 8731366 [details] [diff] [review]
extend-youtube-telemetry-period.patch
Chris, you are still actively monitoring this data? data-review=me if that's the case. If you're actively monitoring and believe this is valuable, why don't we make it opt-out?
Attachment #8731366 -
Flags: review?(benjamin) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #3)
> Chris, you are still actively monitoring this data? data-review=me if that's
> the case. If you're actively monitoring and believe this is valuable, why
> don't we make it opt-out?
Yes because the Flash embed rewriter has not hit the Release channel yet. We want to see if this probe changes after it does.
I will make this opt-out, starting in 48. Changing from opt-in to opt-out users may affect the data, so we will just need to remember that we may see a discontinuity in 48's results.
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•