Closed
Bug 1354778
Opened 8 years ago
Closed 8 years ago
Remove or renew some expired telemetry probes for Flash content
Categories
(Core Graveyard :: Plug-ins, enhancement)
Core Graveyard
Plug-ins
Tracking
(firefox52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
mozilla55
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(3 files, 1 obsolete file)
* PLUGIN_BLOCKED_FOR_STABILITY expires in version 52.0a1 (watched by cpeterson@mozilla.com) - Count plugins blocked for stability
* PLUGIN_TINY_CONTENT expires in version 52.0a1 (watched by cpeterson@mozilla.com) - Count tiny plugin content
* PLUGIN_ACTIVATION_COUNT expires in version 53.0a1 (watched by cpeterson@mozilla.com) - Counts number of times a certain plugin has been activated.
* YOUTUBE_NONREWRITABLE_EMBED_SEEN expires in version 53.0a1 (watched by cpeterson@mozilla.com) - Flag activated whenever a non-rewritable (enablejsapi=1) youtube flash embed is seen during a session.
* YOUTUBE_REWRITABLE_EMBED_SEEN expires in version 53.0a1 (watched by cpeterson@mozilla.com) - Flag activated whenever a rewritable youtube flash embed is seen during a session.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8856081 [details]
Bug 1354778 - Remove expired telemetry probes YOUTUBE_REWRITABLE_EMBED_SEEN and YOUTUBE_NONREWRITABLE_EMBED_SEEN.
https://reviewboard.mozilla.org/r/128018/#review130566
Attachment #8856081 -
Flags: review?(kyle) → review+
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8856082 [details]
Bug 1354778 - Remove expired telemetry probes PLUGIN_ACTIVATION_COUNT and PLUGIN_TINY_CONTENT.
https://reviewboard.mozilla.org/r/128020/#review130920
Be aware that I just removed FLASH_PLUGIN_\* in bug 1345905, but we still have a count of plugins instantiated via the count of BLOCKED_ON_PLUGIN_INSTANCE_INIT_MS so I'm ok with losing this now.
Attachment #8856082 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8856084 [details]
Bug 1354778 - Renew expired Flash telemetry probes until 2018 Q4.
Removing review request to renew the FLASH_PLUGIN_* probes because they were just removed in bug 1345905.
Attachment #8856084 -
Attachment is obsolete: true
Attachment #8856084 -
Flags: review?(benjamin)
Assignee | ||
Updated•8 years ago
|
Attachment #8856084 -
Attachment is obsolete: false
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8856084 -
Attachment is obsolete: true
Comment 11•8 years ago
|
||
mozreview-review |
Comment on attachment 8856083 [details]
Bug 1354778 - Remove expired telemetry probe PLUGIN_BLOCKED_FOR_STABILITY.
https://reviewboard.mozilla.org/r/128022/#review131618
r=me with that change
::: toolkit/components/telemetry/Histograms.json
(Diff revision 2)
> "expires_in_version": "never",
> "kind": "enumerated",
> "n_values": 10,
> "description": "Media decoder backend (0=WMF Software, 1=DXVA2D3D9, 2=DXVA2D3D11)"
> },
> - "PLUGIN_BLOCKED_FOR_STABILITY": {
This also needs to be removed from histogram-whitelists.json or it will cause a build error.
Attachment #8856083 -
Flags: review?(benjamin) → review+
Comment 12•8 years ago
|
||
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c97aecf246c
Remove expired telemetry probes PLUGIN_ACTIVATION_COUNT and PLUGIN_TINY_CONTENT. r=bsmedberg
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e851455efd
Remove expired telemetry probe PLUGIN_BLOCKED_FOR_STABILITY. r=bsmedberg
https://hg.mozilla.org/integration/mozilla-inbound/rev/b86cd9bfeceb
Remove expired telemetry probes YOUTUBE_REWRITABLE_EMBED_SEEN and YOUTUBE_NONREWRITABLE_EMBED_SEEN. r=qdot
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c97aecf246c
https://hg.mozilla.org/mozilla-central/rev/a3e851455efd
https://hg.mozilla.org/mozilla-central/rev/b86cd9bfeceb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Updated•8 years ago
|
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•