Closed
Bug 1262465
Opened 9 years ago
Closed 8 years ago
ensure unprivileged users can mark a bug as security sensitive
Categories
(bugzilla.mozilla.org :: User Interface, defect, P1)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: dkl)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
ensure unprivileged users can mark a bug as security sensitive - basically implement bug 504461 in bug-modal.
|
||
Updated•8 years ago
|
Assignee: nobody → dylan
|
|
||
Updated•8 years ago
|
Priority: -- → P1
|
||
Comment 1•8 years ago
|
||
|
|
||
Comment 2•8 years ago
|
||
I haven't finished reviewing this yet, however it has lead me to believe we regressed on bug 504461.
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8773956 [details]
rev1
This didn't work out -- however it did uncover that one of my products had an empty string for its default group. Reloading my DB fixed this. Weird.
Attachment #8773956 -
Flags: review?(dylan) → review-
|
|
||
Updated•8 years ago
|
Assignee: sebastinssanty → dylan
|
|
||
Comment 4•8 years ago
|
||
still working on this.
changes so far:
1) always display security module
2) this means the subtitle and on-show content has to either be "public" (for public bugs) or show a shorthand of
why the bug is visible (report/cc accessible). Of course if the bug is private to a group and a user is a member of that group, it displays as before.
|
||
Updated•8 years ago
|
Assignee: dylan → dkl
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8773956 -
Attachment is obsolete: true
Attachment #8821613 -
Flags: review?(dylan)
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8821613 [details] [diff] [review]
1262465_1.patch
Review of attachment 8821613 [details] [diff] [review]:
-----------------------------------------------------------------
oops need one more change
Attachment #8821613 -
Flags: review?(dylan)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Attachment #8821613 -
Attachment is obsolete: true
Attachment #8821616 -
Flags: review?(dylan)
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8821616 [details] [diff] [review]
1262465_2.patch
Review of attachment 8821616 [details] [diff] [review]:
-----------------------------------------------------------------
r=dylan
Attachment #8821616 -
Flags: review?(dylan) → review+
|
|
Assignee | |
Comment 9•8 years ago
|
||
To https://github.com/mozilla-bteam/bmo.git
cad5c15..550a798 master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: User Interface: Modal → User Interface
You need to log in
before you can comment on or make changes to this bug.
Description
•