Closed
Bug 1328464
Opened 8 years ago
Closed 8 years ago
The checkbox of "Add me to CC list (follow this bug)" doesn't work
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: xidorn, Assigned: dylan)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
I found that when I leave the checkbox "Add me to CC list (follow this bug)" untouched (checked) and click "Save Changes", either with or without other changes, it doesn't make me follow the bug.
The "Follow" button continue working, though.
Reporter | ||
Comment 1•8 years ago
|
||
Not sure whether it is a bmo bug or a bugzilla bug, and not sure what is the proper component for it.
Comment 2•8 years ago
|
||
This hit me twice this morning with Bug 1325743 and bug 1285563
And I'm pretty sure also some time yesterday.
pretty insideous
Comment 3•8 years ago
|
||
Dang, I also didn't get CC on this bug when I commented
Severity: normal → major
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dylan
Assignee | ||
Comment 4•8 years ago
|
||
Regression caused by bug 1262465
Depends on: 1262465
Flags: needinfo?(dkl)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8823658 -
Flags: review?(dkl)
Comment 6•8 years ago
|
||
Comment on attachment 8823658 [details] [diff] [review]
1328464_2.patch
Review of attachment 8823658 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh, sorry. I did this as I was adding them to cc if they marked the bug as sec sensitive and they had no role on the bug automatically. So we also need to change
https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/web/bug_modal.js#L1123
and make it set to true only if not true already. Right now it would set it to false if someone unchecks make this sec sensitive after checking it. Can you fix that on commit please?
r=dkl
Attachment #8823658 -
Flags: review?(dkl) → review+
Comment 7•8 years ago
|
||
(In reply to David Lawrence [:dkl] from comment #6)
> Comment on attachment 8823658 [details] [diff] [review]
> 1328464_2.patch
>
> Review of attachment 8823658 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Ugh, sorry. I did this as I was adding them to cc if they marked the bug as
> sec sensitive and they had no role on the bug automatically. So we also need
> to change
>
> https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/web/
> bug_modal.js#L1123
>
> and make it set to true only if not true already. Right now it would set it
> to false if someone unchecks make this sec sensitive after checking it. Can
> you fix that on commit please?
>
> r=dkl
I propose:
// Add user to cc list if they mark the bug as security sensitive
$('.restrict_sensitive')
.change(function(event) {
if ($('#addselfcc').val() == 0)
$('#addselfcc').val(1);
});
Assignee | ||
Comment 8•8 years ago
|
||
Going with:
$('.restrict_sensitive')
.change(function(event) {
$('#add-self-cc:not(:checked)').attr('checked', true);
});
Assignee | ||
Comment 9•8 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git
550a798..ad7cbed master -> master
To git@github.com:mozilla-bteam/bmo.git
ad7cbed..e3f7a84 master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: User Interface: Modal → User Interface
You need to log in
before you can comment on or make changes to this bug.
Description
•