Closed Bug 1262584 Opened 9 years ago Closed 9 years ago

Some [component:error] messages are not appearing as errors in Treeherder

Categories

(Tree Management :: Treeherder: Data Ingestion, defect)

Product:
Tree Management
Component:
Treeherder: Data Ingestion
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: garndt, Assigned: garndt)

References

Details

Attachments

(1 file, 1 obsolete file)

https://github.com/mozilla/treeherder/pull/1392
(deleted), text/x-github-pull-request
wlach
: review+
Details
[test.sh:error] is not getting parsed from the logs and displayed on treeherder when there is an error Example: https://tools.taskcluster.net/task-inspector/#dS8qWfFiTTWKYTf5VFL5sw/0 Which is this Treeherder job: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=c111173a1b98ae219a1172cd7fb15dc8c629e2a2&selectedJob=25265477
Is this an error in the log parser? Is it the `.`?
It's the '.' because the regex was limited in what it was looking for. I'm going to updated the regex to something like: ^\[[\w._-]+:(?:error|exception)\]
Attachment #8738739 - Flags: review?(cdawson)
Comment on attachment 8738739 [details] https://github.com/mozilla/treeherder/pull/1392 I'm going to steal this review and give it an r+. Seems like a no-brainer, and I'm about to deploy to stage for testing so this might as well come along for the ride.
Attachment #8738739 - Flags: review?(cdawson) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f12d860785e80088ca2a69cb1a62c81da1697502 Bug 1262584 - Improve taskcluster error regex https://github.com/mozilla/treeherder/commit/eed5606fa62666ba0d551991e0e80de4fecd6574 Merge pull request #1392 from gregarndt/improve_error_regex Bug 1262584 - Improve taskcluster error regex
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8738738 - Attachment is obsolete: true
Many thanks for fixing this :-)
Component: Integration → Treeherder: Data Ingestion
Product: Taskcluster → Tree Management
Version: unspecified → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: