Closed
Bug 1264060
Opened 9 years ago
Closed 9 years ago
Nexus 5 L and Aries builds (eng/debug) (including blobfree) are not pushed to Taskcluster artifacts repo correctly.
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
2.6 S12 - 4/22
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: nhirata, Assigned: nhirata)
References
Details
(Whiteboard: fixed-in-pine)
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
1. see https://treeherder.mozilla.org/#/jobs?repo=pine&selectedJob=13224&filter-searchStr=B2G%20Device%20Image%20opt%20Aries%20Device%20Image%20[TC]%20B2G%20Aries%20Eng%20Aries%28Be%29
Errors received:
The directory '/home/worker/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Return code: 0
rm: cannot remove `out/target/product/aries/aries.blobfree-dist.zip': No such file or directory
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
The build should be here. see log : https://tools.taskcluster.net/task-inspector/#Eq0yGq_HRye3phi7j9oi_Q/
Assignee | ||
Updated•9 years ago
|
Summary: Aries build is not pushed to Taskcluster repo correctly. → Aries build (including blobfree) is not pushed to Taskcluster repo correctly.
Comment 2•9 years ago
|
||
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #0)
[...]
> rm: cannot remove `out/target/product/aries/aries.blobfree-dist.zip': No
> such file or directory
This is harmless, we print this as part of the building process of blobfree.
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for letting me know. That's good to know; at the same time the build is failing still:
11:02:20 DEBUG - Copying /home/worker/objdir-gecko/objdir/dist/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz to /home/worker/workspace/B2G/upload-public/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz
...
mv: cannot stat `/home/worker/workspace/B2G/upload/b2g-*.android-arm.tar.gz': No such file or directory
It looks like the wrong directory was used and this might be the reason for the failure?
Assignee | ||
Updated•9 years ago
|
Summary: Aries build (including blobfree) is not pushed to Taskcluster repo correctly. → Nexus 5 L and Aries builds (eng/debug) (including blobfree) are not pushed to Taskcluster artifacts repo correctly.
Assignee | ||
Comment 4•9 years ago
|
||
Turns out that Nexus 5 L on MC are affected as well.
Assignee | ||
Comment 5•9 years ago
|
||
Not sure if this is the appropriate patch, need to test...
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Woops. The old way of building doesn't work. need to talk to taskcluster team to find out how to test my patch.
Assignee | ||
Comment 8•9 years ago
|
||
The try graph is here : https://tools.taskcluster.net/task-graph-inspector/#cJglsQ8bRsaQCwSE5btpgQ
Having said that, I found out from garndt that Bug 1220704 — FIXED, wcosta@mozilla.com — Remove docker-worker:image:taskclusterprivate/phone-builder:* from moz-tree:level:1 role
So I wouldn't be able to see my results there. Wander is on PTO so I don't know how to test my patch.
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8741077 [details] [diff] [review]
0001-bug-1264060-Nexus-5-L-and-Aries-builds-are-not-pushe.patch
Review of attachment 8741077 [details] [diff] [review]:
-----------------------------------------------------------------
Alexandre, could you review the patch? I think the rename and relocation of the android tar ball is causing the issue with the build failure.
Attachment #8741077 -
Flags: review?(lissyx+mozillians)
Comment 10•9 years ago
|
||
Comment on attachment 8741077 [details] [diff] [review]
0001-bug-1264060-Nexus-5-L-and-Aries-builds-are-not-pushe.patch
Review of attachment 8741077 [details] [diff] [review]:
-----------------------------------------------------------------
I guess this is the proper path forward and we can even fix things that were broken for a long time. So it's okay for me with those changes included.
Wander (:wcosta) could also have a look at this (but he seems to be PTO until 18/04) :)
::: testing/taskcluster/scripts/phone-builder/post-build.sh
@@ +13,4 @@
> DEVICE=${TARGET%%-*}
>
> mv $WORKSPACE/B2G/upload/sources.xml $HOME/artifacts/sources.xml
> +mv $WORKSPACE/B2G/upload-public/b2g-*.android*-arm.tar.gz $HOME/artifacts/b2g-android*-arm.tar.gz
I guess we want to move to artifacts-public since this tarball only contains free software?
@@ +17,2 @@
> mv $WORKSPACE/B2G/upload/${TARGET}.zip $HOME/artifacts/${TARGET}.zip
> mv $WORKSPACE/B2G/upload/gaia.zip $HOME/artifacts/gaia.zip
We could do the same for gaia.zip
Attachment #8741077 -
Flags: review?(lissyx+mozillians) → review+
Updated•9 years ago
|
Assignee: nobody → nhirata.bugzilla
Assignee | ||
Comment 11•9 years ago
|
||
Ya, I agree; we can make the other parts public. I'll do that in another bug.
Since the builds are blocked for try, I can't test. The scope in taskcluster doesn't allow for it ( see Bug 1220704 ). Since the builds are broken, you're right. I don't see too much harm in pushing.
Wes, could you checkin please?
Flags: needinfo?(wkocher)
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 13•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47727/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47727/
Attachment #8743371 -
Flags: review?(lissyx+mozillians)
Updated•9 years ago
|
Attachment #8743371 -
Flags: review?(lissyx+mozillians) → review+
Comment 14•9 years ago
|
||
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax
https://reviewboard.mozilla.org/r/47727/#review44525
Comment 15•9 years ago
|
||
Comment 16•9 years ago
|
||
Whiteboard: fixed-in-pine
Comment 17•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S12 - 4/22
Comment 18•9 years ago
|
||
Okay that patch is not good, I missed the fact that the tarball is named "b2g-48.0a1-..." :/
Comment 19•9 years ago
|
||
backed out in https://hg.mozilla.org/mozilla-central/rev/4e3ad95d689a
Status: RESOLVED → REOPENED
Flags: needinfo?(nhirata.bugzilla)
Resolution: FIXED → ---
Comment 21•9 years ago
|
||
So, in the past, we had:
> mv $WORKSPACE/B2G/upload/b2g-*.android-arm.tar.gz $HOME/artifacts/b2g-android-arm.tar.gz
And the build system was producing:
> 19:19:36 DEBUG - Copying /home/worker/objdir-gecko/objdir/dist/b2g-48.0a1.en-US.android-arm.tar.gz to /home/worker/workspace/B2G/upload-public/b2g-48.0a1.en-US.android-arm.tar.gz
Today, we have:
> 19:27:45 DEBUG - Copying /home/worker/objdir-gecko/objdir/dist/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz to /home/worker/workspace/B2G/upload-public/b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz
So it becomes obvious that |b2g-*.android-arm.tar.gz| cannot match |b2g-48.0a1.en-US.linux-androideabi-arm.tar.gz|, since the |android-arm| string became a standard triplet |linux-androideabi-arm|.
Comment 22•9 years ago
|
||
Comment 23•9 years ago
|
||
Updated•9 years ago
|
Attachment #8741077 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8743371 -
Attachment is obsolete: true
Comment 24•9 years ago
|
||
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax
https://reviewboard.mozilla.org/r/47727/#review44819
Attachment #8743371 -
Flags: review+
Comment 25•9 years ago
|
||
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax
https://reviewboard.mozilla.org/r/47727/#review44821
Attachment #8743371 -
Flags: review+
Comment 26•9 years ago
|
||
Attachment #8743782 -
Flags: review+
Comment 27•9 years ago
|
||
Comment on attachment 8743782 [details] [diff] [review]
Update arch triplet for B2G builds
Sorry for this, but I am unable to repush to mozreview to and the fix :/
Flags: needinfo?(cbook)
Comment 28•9 years ago
|
||
Comment on attachment 8743371 [details]
MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47727/diff/1-2/
Attachment #8743371 -
Attachment description: MozReview Request: bug 1264060 - Nexus 5 L and Aries builds are not pushed to Taskcluster artifacts repo correctly. r?gerard-majax → MozReview Request: Bug 1264060 - Update arch triplet for B2G builds r?gerard-majax
Attachment #8743371 -
Attachment is obsolete: false
Updated•9 years ago
|
Attachment #8743782 -
Attachment is obsolete: true
Flags: needinfo?(cbook)
Comment 29•9 years ago
|
||
Re-uploading because we need to land directly on m-c
Attachment #8743804 -
Flags: review+
Updated•9 years ago
|
Flags: needinfo?(cbook)
Comment 31•9 years ago
|
||
Keywords: checkin-needed
Comment 32•9 years ago
|
||
relanded as relanded as https://hg.mozilla.org/mozilla-central/rev/1152d99d8c53
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(cbook)
Resolution: --- → FIXED
Updated•9 years ago
|
Attachment #8743371 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•